refactor: Use improved MenuService DX methods

Update all components and routes to use the new DX-friendly MenuService API:

Components updated:
- layout/fleet-ops-sidebar.js: Use menuService.getMenuItems() and getMenuPanels()
- map/drawer.js: Use menuService.getMenuItems()
- map/leaflet-live-map.js: Use menuService.getMenuItems()
- order-config-manager.js: Use menuService.getMenuItems()

Routes updated:
- routes/virtual.js: Use menuService.lookupMenuItem() instead of manual find()

Benefits:
- Clear, intuitive API: getMenuItems() instead of getRegistry()
- Simplified lookups: lookupMenuItem(reg, slug, view, section) instead of manual filtering
- Better DX: Method names reflect intent, not implementation
- Consistent with ember-core feature/universe-refactor improvements

Requires: ember-core feature/universe-refactor (commit 40d2921)

Author: roncodes

addon/components/layout/fleet-ops-sidebar.js

@@ -7,7 +7,7 @@ import DriverListingComponent from './fleet-ops-sidebar/driver-listing';
 
 export default class LayoutFleetOpsSidebarComponent extends Component {
     @service universe;
-    @service('universe/registry-service') registryService;
+    @service('universe/menu-service') menuService;
     @service store;
     @service intl;
     @service abilities;
@@ -25,8 +25,8 @@ export default class LayoutFleetOpsSidebarComponent extends Component {
     }
 
     createMenuItemsFromUniverseRegistry() {
-        const registeredMenuItems = this.registryService.getRegistry('engine:fleet-ops');
-        this.universeMenuPanels = this.registryService.getRegistry('engine:fleet-ops:panels');
+        const registeredMenuItems = this.menuService.getMenuItems('engine:fleet-ops');
+        this.universeMenuPanels = this.menuService.getMenuPanels('engine:fleet-ops');
         this.universeMenuItems = registeredMenuItems.filter((menuItem) => menuItem.section === undefined);
         this.universeSettingsMenuItems = registeredMenuItems.filter((menuItem) => menuItem.section === 'settings');
     }

addon/components/map/drawer.js

@@ -6,10 +6,10 @@ import { isArray } from '@ember/array';
 export default class MapDrawerComponent extends Component {
     @service mapDrawer;
     @service universe;
-    @service('universe/registry-service') registryService;
+    @service('universe/menu-service') menuService;
 
     get tabs() {
-        const registeredTabs = this.registryService.getRegistry('fleet-ops:component:map:drawer');
+        const registeredTabs = this.menuService.getMenuItems('fleet-ops:component:map:drawer');
         return [
             this.universe._createMenuItem('Vehicles', null, { icon: 'car', component: 'map/drawer/vehicle-listing' }),
             this.universe._createMenuItem('Drivers', null, { icon: 'id-card', component: 'map/drawer/driver-listing' }),

addon/components/map/leaflet-live-map.js

@@ -28,7 +28,7 @@ export default class MapLeafletLiveMapComponent extends Component {
     @service abilities;
     @service intl;
     @service universe;
-    @service('universe/registry-service') registryService;
+    @service('universe/menu-service') menuService;
 
     /** properties */
     id = guidFor(this);
@@ -405,7 +405,7 @@ export default class MapLeafletLiveMapComponent extends Component {
         ];
 
         // append items from universe registry
-        const registeredContextMenuItems = this.registryService.getRegistry('fleet-ops:contextmenu:driver');
+        const registeredContextMenuItems = this.menuService.getMenuItems('fleet-ops:contextmenu:driver');
         if (isArray(registeredContextMenuItems)) {
             items = [
                 ...items,
@@ -453,7 +453,7 @@ export default class MapLeafletLiveMapComponent extends Component {
         ];
 
         // append items from universe registry
-        const registeredContextMenuItems = this.registryService.getRegistry('fleet-ops:contextmenu:vehicle');
+        const registeredContextMenuItems = this.menuService.getMenuItems('fleet-ops:contextmenu:vehicle');
         if (isArray(registeredContextMenuItems)) {
             items = [
                 ...items,

addon/components/order-config-manager.js

@@ -20,7 +20,7 @@ import findActiveTab from '../utils/find-active-tab';
 const configManagerContext = EmberObject.extend(Evented);
 export default class OrderConfigManagerComponent extends Component {
     @service universe;
-    @service('universe/registry-service') registryService;
+    @service('universe/menu-service') menuService;
     @service notifications;
     @service modalsManager;
     @service store;
@@ -40,7 +40,7 @@ export default class OrderConfigManagerComponent extends Component {
      * @type {Array}
      */
     get tabs() {
-        const registeredTabs = this.registryService.getRegistry('fleet-ops:component:order-config-manager');
+        const registeredTabs = this.menuService.getMenuItems('fleet-ops:component:order-config-manager');
         const defaultTabs = [
             this.universe._createMenuItem(this.intl.t('order-config-manager.tabs.details'), null, { icon: 'circle-info', component: OrderConfigManagerDetailsComponent }),
             this.universe._createMenuItem(this.intl.t('order-config-manager.tabs.custom-fields'), null, { icon: 'rectangle-list', component: OrderConfigManagerCustomFieldsComponent }),

addon/routes/virtual.js

@@ -3,7 +3,7 @@ import { inject as service } from '@ember/service';
 
 export default class VirtualRoute extends Route {
     @service universe;
-    @service('universe/registry-service') registryService;
+    @service('universe/menu-service') menuService;
 
     queryParams = {
         view: {
@@ -13,12 +13,6 @@ export default class VirtualRoute extends Route {
 
     model({ section = null, slug }, transition) {
         const view = this.universe.getViewFromTransition(transition);
-        const items = this.registryService.getRegistry('engine:fleet-ops');
-        return items.find(item => {
-            const slugMatch = item.slug === slug;
-            const viewMatch = !view || item.view === view;
-            const sectionMatch = !section || item.section === section;
-            return slugMatch && viewMatch && sectionMatch;
-        });
+        return this.menuService.lookupMenuItem('engine:fleet-ops', slug, view, section);
     }
 }