v0.6.28#192
Merged
Merged
Conversation
- Replace universe.getMenuItemsFromRegistry with registryService.getMenuItems - Replace universe.getMenuPanelsFromRegistry with registryService.getMenuPanels - Replace universe.lookupMenuItemFromRegistry with registryService.lookupMenuItem - Replace universe.createRegistryEvent with registryService.createEvent - Replace universe.registerHeaderMenuItem with menuService.registerHeaderMenuItem - Replace universe.registerMenuItem with menuService.registerMenuItem - Replace universe.registerAdminMenuPanel with menuService.registerAdminMenuPanel - Replace universe.registerDefaultDashboardWidgets with widgetService.registerDefaultWidgets - Replace universe.registerDashboardWidgets with widgetService.registerWidgets - Replace universe.afterBoot with extensionManager.afterBoot - Replace universe.createRegistries with registryService.createRegistries Updated files: - addon/components/layout/fleet-ops-sidebar.js - addon/components/map/drawer.js - addon/components/map/leaflet-live-map.js - addon/components/order-config-manager.js - addon/engine.js - addon/extension.js - addon/routes/virtual.js - addon/utils/setup-customer-portal.js This refactoring aligns with the universe service decomposition in ember-core, improving performance and maintainability by using specialized services instead of the monolithic universe service.
Refactor to use the new specialized services instead of monolithic universe: - Use menuService for menu registration - Use widgetService for widget registration - Use registryService for registry operations - Use extensionManager for extension lifecycle Files updated: - addon/extension.js - Use menuService.registerHeaderMenuItem() - addon/engine.js - Use menuService, widgetService, registryService - addon/utils/setup-customer-portal.js - Use extensionManager.afterBoot(), menuService, registryService - addon/components/order-config-manager.js - Use registryService.getRegistry() - addon/routes/virtual.js - Use registryService.getRegistry() with manual lookup - addon/components/map/leaflet-live-map.js - Use registryService.getRegistry(), universe.trigger() - addon/components/layout/fleet-ops-sidebar.js - Use registryService.getRegistry() - addon/components/map/drawer.js - Use registryService.getRegistry() This migration: - Improves performance with O(1) lookups - Phases out backward compatibility facade methods - Aligns with ember-core's new architecture - Maintains all functionality while using proper new API Requires: ember-core feature/universe-refactor branch
roncodes
force-pushed
the
dev-v0.6.28
branch
from
1eb2252 to
623fa0c
Compare
Update all components and routes to use the new DX-friendly MenuService API: Components updated: - layout/fleet-ops-sidebar.js: Use menuService.getMenuItems() and getMenuPanels() - map/drawer.js: Use menuService.getMenuItems() - map/leaflet-live-map.js: Use menuService.getMenuItems() - order-config-manager.js: Use menuService.getMenuItems() Routes updated: - routes/virtual.js: Use menuService.lookupMenuItem() instead of manual find() Benefits: - Clear, intuitive API: getMenuItems() instead of getRegistry() - Simplified lookups: lookupMenuItem(reg, slug, view, section) instead of manual filtering - Better DX: Method names reflect intent, not implementation - Consistent with ember-core feature/universe-refactor improvements Requires: ember-core feature/universe-refactor (commit 40d2921)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.