fix(place): update PhoneInput onInput handler to mutate place phone#278
Open
spanchenko wants to merge 1 commit into
Open
fix(place): update PhoneInput onInput handler to mutate place phone#278spanchenko wants to merge 1 commit into
spanchenko wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description:
Summary
Fixes an issue where saving or updating a Place entity stored phone numbers without the international country dial code (E.164 format).
Cause of the Issue
this.phoneis not defined inPlaceFormComponent, resolving@onInputtoundefined.the country dial code prefix, causing only raw input text to be saved instead of the formatted E.164 phone string.
Solution
forms across the codebase (such as
contact/form.hbs,driver/form.hbs,customer/form.hbs, andvendor/form.hbs), ensuringphone numbers are correctly mutated and stored in standard E.164 format (e.g.
+1...,+7...).Changes