fix(geocoding): support configured google maps locale in geocoding re…#279
Open
spanchenko wants to merge 1 commit into
Open
fix(geocoding): support configured google maps locale in geocoding re…#279spanchenko wants to merge 1 commit into
spanchenko wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, Google Maps geocoding and reverse-geocoding requests in
FleetOpsalways return address details and street names in English. This happens becauseGeocoding.phphardcodes'en'as the locale forStatefulGeocoderand passesnullas the region to theGoogleMapsprovider, ignoring the system-configuredservices.google_maps.localesetting.This PR introduces dynamic locale support by retrieving the configured locale (
config('services.google_maps.locale', env('GOOGLE_MAPS_LOCALE', 'en'))) and passing it to both theGoogleMapsprovider (for region bias) and StatefulGeocoder` (for localized language response).Changes
Geocoding::getLocale()helper method to retrieve the configured locale.geocode(),reverseFromQuery(), andreverseFromCoordinates()inGeocoding.phpto usegetLocale()instead of hardcoded'en'andnullregion parameters.How to Test
Settings -> Services -> Google Maps) with API key and setgoogle_maps_localeto a non-English locale (e.g.ru,es,fr).