Skip to content

Add custom CVE matching rule for CVE-2026-5870 (Chrome Skia integer overflow) #43463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kilo-code-bot wants to merge 1 commit into
base: main
Choose a base branch
from
+55 −1
Open

Add custom CVE matching rule for CVE-2026-5870 (Chrome Skia integer overflow) #43463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions server/vulnerabilities/customcve/matching_rules.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,14 @@ func getCVEMatchingRules() CVEMatchingRules {
CVEs: []string{"CVE-2026-20841"},
ResolvedInVersion: "11.2510",
},
// April 2026 Google Chrome Skia integer overflow vulnerability
// https://chromereleases.googleblog.com/2026/04/stable-channel-update-for-desktop.html
{
NameLikeMatch: "Google Chrome",
ExcludeIfNameContains: "helper",
CVEs: []string{"CVE-2026-5870"},
ResolvedInVersion: "147.0.7727.55",
},
}
}

Expand Down
48 changes: 47 additions & 1 deletion server/vulnerabilities/customcve/matching_rules_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,34 @@ func TestCheckCustomVulnerabilities(t *testing.T) {
Version: "11.2510.14.0",
Source: "programs",
},
// Google Chrome vulnerable version (Windows) should match CVE-2026-5870
{
ID: 10,
Name: "Google Chrome",
Version: "146.0.7680.165",
Source: "programs",
},
// Google Chrome vulnerable version (macOS) should match CVE-2026-5870
{
ID: 11,
Name: "Google Chrome.app",
Version: "146.0.7680.165",
Source: "apps",
},
// Google Chrome patched version should not match CVE-2026-5870
{
ID: 12,
Name: "Google Chrome",
Version: "147.0.7727.55",
Source: "programs",
},
// Google Chrome Helper should be excluded from CVE-2026-5870
{
ID: 13,
Name: "Google Chrome Helper.app",
Version: "146.0.7680.165",
Source: "apps",
},
}

t.Run("New Vulns return all inserted", func(t *testing.T) {
Expand All @@ -336,13 +364,17 @@ func TestCheckCustomVulnerabilities(t *testing.T) {
if filter.Name == "Microsoft.WindowsNotepad" && filter.Source == "programs" {
return []fleet.Software{sw[7], sw[8]}, nil
}
if filter.Name == "Google Chrome" && filter.Source == "" {
return []fleet.Software{sw[9], sw[10], sw[11], sw[12]}, nil
}
return nil, nil
}

ds.InsertSoftwareVulnerabilitiesFunc = func(ctx context.Context, vulns []fleet.SoftwareVulnerability, source fleet.VulnerabilitySource) ([]fleet.SoftwareVulnerability, error) {
require.Equal(t, fleet.CustomSource, source)
for _, v := range vulns {
require.NotEqual(t, uint(7), v.SoftwareID, "Microsoft 365 companion apps should be excluded from CVE matching")
require.NotEqual(t, uint(13), v.SoftwareID, "Google Chrome Helper should be excluded from CVE matching")
}
return vulns, nil // all inserted vulns are "new"
}
Expand All @@ -355,7 +387,7 @@ func TestCheckCustomVulnerabilities(t *testing.T) {
ctx := context.Background()
vulns, err := CheckCustomVulnerabilities(ctx, ds, slog.New(slog.DiscardHandler), time.Now().UTC().Add(-time.Hour))
require.NoError(t, err)
require.Len(t, vulns, 35)
require.Len(t, vulns, 37)
require.True(t, ds.DeleteOutOfDateVulnerabilitiesFuncInvoked)

expected := []fleet.SoftwareVulnerability{
Expand Down Expand Up @@ -534,6 +566,16 @@ func TestCheckCustomVulnerabilities(t *testing.T) {
CVE: "CVE-2026-20841",
ResolvedInVersion: ptr.String("11.2510"),
},
{
SoftwareID: 10,
CVE: "CVE-2026-5870",
ResolvedInVersion: ptr.String("147.0.7727.55"),
},
{
SoftwareID: 11,
CVE: "CVE-2026-5870",
ResolvedInVersion: ptr.String("147.0.7727.55"),
},
}

cmpSoftwareVulnerability := func(v []fleet.SoftwareVulnerability) func(i, j int) bool {
Expand Down Expand Up @@ -565,6 +607,9 @@ func TestCheckCustomVulnerabilities(t *testing.T) {
if filter.Name == "Microsoft.WindowsNotepad" && filter.Source == "programs" {
return []fleet.Software{sw[7], sw[8]}, nil
}
if filter.Name == "Google Chrome" && filter.Source == "" {
return []fleet.Software{sw[9], sw[10], sw[11], sw[12]}, nil
}
return nil, nil
}

Expand All @@ -573,6 +618,7 @@ func TestCheckCustomVulnerabilities(t *testing.T) {
require.Equal(t, fleet.CustomSource, source)
for _, v := range vulns {
require.NotEqual(t, uint(7), v.SoftwareID, "Microsoft 365 companion apps should be excluded from CVE matching")
require.NotEqual(t, uint(13), v.SoftwareID, "Google Chrome Helper should be excluded from CVE matching")
}
return nil, nil
}
Expand Down
Loading