Skip to content

48343 edit config profile UI#49333

Draft
JordanMontgomery wants to merge 7 commits into
48342-edit-config-profile-endpointfrom
48343-edit-config-profile-ui
Draft

48343 edit config profile UI#49333
JordanMontgomery wants to merge 7 commits into
48342-edit-config-profile-endpointfrom
48343-edit-config-profile-ui

Conversation

@JordanMontgomery

Copy link
Copy Markdown
Member

Related issue: Resolves #

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters.

  • Timeouts are implemented and retries are limited to avoid infinite loops

  • If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes

Testing

For unreleased bug fixes in a release candidate, one of:

  • Confirmed that the fix is not expected to adversely impact load test results
  • Alerted the release DRI if additional load testing is needed

Database migrations

  • Checked schema for all modified table for columns that will auto-update timestamps during migration.
  • Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects.
  • Ensured the correct collation is explicitly set for character columns (COLLATE utf8mb4_unicode_ci).

New Fleet configuration settings

  • Setting(s) is/are explicitly excluded from GitOps

If you didn't check the box above, follow this checklist for GitOps-enabled settings:

  • Verified that the setting is exported via fleetctl generate-gitops
  • Verified the setting is documented in a separate PR to the GitOps documentation
  • Verified that the setting is cleared on the server if it is not supplied in a YAML file (or that it is documented as being optional)
  • Verified that any relevant UI is disabled when GitOps mode is enabled

fleetd/orbit/Fleet Desktop

  • Verified compatibility with the latest released version of Fleet (see Must rule)
  • If the change applies to only one platform, confirmed that runtime.GOOS is used as needed to isolate changes
  • Verified that fleetd runs on macOS, Linux and Windows
  • Verified auto-update works from the released version of component to the new version (see tools/tuf/test)

Edit profile modal (contents and/or labels), pencil row action replacing
the labels-filter button per design, updateProfile API client, and the
edited_configuration_profile activity in the global feed.
- Premium-gate team resolution in the profile update and delete paths:
  svc.EnterpriseOverrides is nil on Fleet Free, so team-scoped edits and
  deletes panicked after a premium-to-free downgrade
- Preserve Fleet-variable associations on labels-only edits (Apple,
  Windows, DDM) -- clearing them broke variable-driven redelivery
- Enforce PayloadScope conflicts and cross-platform name uniqueness on
  Apple profile content edits, matching the create/GitOps paths
- Route post-update reads to the primary DB and dedupe the labels-only
  validation blocks
Main introduced Android profile Fleet-variable tracking and a DDM scope
column after the edit endpoint was written:
- UpdateMDMAndroidConfigProfile now takes usesFleetVars and applies the
  same content-only variable-association semantics as Apple/Windows
- a labels-only DDM edit carries the existing scope so the upsert's
  unconditional scope write can't clear it
@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.47170% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.05%. Comparing base (272f925) to head (d6a2a15).

Files with missing lines Patch % Lines
...s/components/EditProfileModal/EditProfileModal.tsx 81.31% 16 Missing and 1 partial ⚠️
frontend/services/entities/mdm.ts 0.00% 12 Missing ⚠️
...ionProfiles/components/ProfileUploader/helpers.tsx 82.92% 7 Missing ⚠️
...vityFeed/GlobalActivityItem/GlobalActivityItem.tsx 81.81% 1 Missing and 1 partial ⚠️
...les/components/ProfileListItem/ProfileListItem.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                        @@
##           48342-edit-config-profile-fixes   #49333    +/-   ##
=================================================================
  Coverage                            68.05%   68.05%            
=================================================================
  Files                                 3783     3783            
  Lines                               240496   240666   +170     
  Branches                             12611    12683    +72     
=================================================================
+ Hits                                163679   163797   +118     
- Misses                               61917    61967    +50     
- Partials                             14900    14902     +2     
Flag Coverage Δ
frontend 59.41% <75.47%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from 48342-edit-config-profile-fixes to 48342-edit-config-profile-endpoint July 15, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant