48343 edit config profile UI#49333
Draft
JordanMontgomery wants to merge 7 commits into
Draft
Conversation
Edit profile modal (contents and/or labels), pencil row action replacing the labels-filter button per design, updateProfile API client, and the edited_configuration_profile activity in the global feed.
- Premium-gate team resolution in the profile update and delete paths: svc.EnterpriseOverrides is nil on Fleet Free, so team-scoped edits and deletes panicked after a premium-to-free downgrade - Preserve Fleet-variable associations on labels-only edits (Apple, Windows, DDM) -- clearing them broke variable-driven redelivery - Enforce PayloadScope conflicts and cross-platform name uniqueness on Apple profile content edits, matching the create/GitOps paths - Route post-update reads to the primary DB and dedupe the labels-only validation blocks
…fig-profile-fixes
Main introduced Android profile Fleet-variable tracking and a DDM scope column after the edit endpoint was written: - UpdateMDMAndroidConfigProfile now takes usesFleetVars and applies the same content-only variable-association semantics as Apple/Windows - a labels-only DDM edit carries the existing scope so the upsert's unconditional scope write can't clear it
JordanMontgomery
temporarily deployed
to
Docker Hub
July 15, 2026 13:55 — with
GitHub Actions
Inactive
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 48342-edit-config-profile-fixes #49333 +/- ##
=================================================================
Coverage 68.05% 68.05%
=================================================================
Files 3783 3783
Lines 240496 240666 +170
Branches 12611 12683 +72
=================================================================
+ Hits 163679 163797 +118
- Misses 61917 61967 +50
- Partials 14900 14902 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Base automatically changed from
48342-edit-config-profile-fixes
to
48342-edit-config-profile-endpoint
July 15, 2026 14:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: Resolves #
Checklist for submitter
If some of the following don't apply, delete the relevant line.
Changes file added for user-visible changes in
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
Input data is properly validated,
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters.Timeouts are implemented and retries are limited to avoid infinite loops
If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes
Testing
Added/updated automated tests
Where appropriate, automated tests simulate multiple hosts and test for host isolation (updates to one hosts's records do not affect another)
QA'd all new/changed functionality manually
For unreleased bug fixes in a release candidate, one of:
Database migrations
COLLATE utf8mb4_unicode_ci).New Fleet configuration settings
If you didn't check the box above, follow this checklist for GitOps-enabled settings:
fleetctl generate-gitopsfleetd/orbit/Fleet Desktop
runtime.GOOSis used as needed to isolate changes