48792 fix actions dropdown layout shift#49430
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #49430 +/- ##
========================================
Coverage 68.16% 68.16%
========================================
Files 3849 3855 +6
Lines 243476 243629 +153
Branches 13124 13166 +42
========================================
+ Hits 165956 166067 +111
- Misses 62521 62562 +41
- Partials 14999 15000 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughUpdated 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@rrahul-1 - hey thanks for the contribution, this ticket is actually waiting on design responses once I get them screenrecordings of a few intended behaviors. Will circle back to you once confirmed |
Related issue: Resolves #48792
Summary
Default
menuPlacementto"auto"inside tables so the menu flips upward when there's no room below, instead of stretching the document. Also addedmarginBottomto match the existingmarginTop: 0, so a flipped-up menu sits flush against its trigger instead of floating 8px above it.Screenshot demonstrating the fix
Checklist for submitter
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
Testing
Manual QA steps
On a local dev server, with enough rows that the page content exactly fills the viewport (no scrollbar):
/labels/manage), Settings → Users (/settings/users), and Settings → Fleets (/settings/fleets)document.documentElement.scrollHeight,clientWidth, andscrollYare unchanged (no scrollbar, no 15px shift, no scroll jump)Summary by CodeRabbit