Fix reticle glitches by updating regl-line

flekschas · flekschas · commit 0d5ad506b68f · 2021-04-08T22:22:19.000-04:00
Fix #46
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## v0.18.1
 
 - Rename `showRecticle` to `showReticle` and `recticleColor` to `reticleColor` (#47)
+- Fix reticle glitches by updating `regl-line` (#46)
 
 ## v0.18.0
 
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -39,7 +39,7 @@
     "lodash-es": "~4.17.21",
     "pub-sub-es": "~2.0.1",
     "regl": "~1.3.13",
-    "regl-line": "~0.4.3",
+    "regl-line": "~0.4.4",
     "with-raf": "~1.1.1"
   },
   "peerDependencies": {
diff --git a/src/index.js b/src/index.js
@@ -802,8 +802,7 @@ const createScatterplot = (initialProperties = {}) => {
 
     // Only ray cast if the mouse cursor is inside
     if (isMouseInCanvas && !lassoActive) {
-      const clostestPoint = raycast();
-      hover(clostestPoint); // eslint-disable-line no-use-before-define
+      hover(raycast()); // eslint-disable-line no-use-before-define
     }
 
     if (lassoActive) lassoManager.extend(event, true);

Original file line number	Diff line number	Diff line change
`@@ -802,8 +802,7 @@ const createScatterplot = (initialProperties = {}) => {`
`802`	`802`
`803`	`803`	`// Only ray cast if the mouse cursor is inside`
`804`	`804`	`if (isMouseInCanvas && !lassoActive) {`
`805`		`- const clostestPoint = raycast();`
`806`		`- hover(clostestPoint); // eslint-disable-line no-use-before-define`
	`805`	`+ hover(raycast()); // eslint-disable-line no-use-before-define`
`807`	`806`	`}`
`808`	`807`
`809`	`808`	`if (lassoActive) lassoManager.extend(event, true);`