Avoid empty lasso events

Author: flekschas

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## v0.16.2
 
 - Stop calling `camera.refresh()` as that is unnecessary since `v1.2.2`
+- Avoid empty lasso events
 
 ## v0.16.1
 

src/index.js

@@ -726,6 +726,7 @@ const createScatterplot = (initialProperties = {}) => {
   };
 
   const mouseDblClickHandler = () => {
+    lassoManager.hideInitiator();
     if (lassoInitiatorTimeout) {
       clearTimeout(lassoInitiatorTimeout);
       lassoInitiatorTimeout = null;

src/lasso-manager/index.js

@@ -197,7 +197,7 @@ const createLasso = (
     });
   };
 
-  const hideinitiator = () => {
+  const hideInitiator = () => {
     const { opacity, scale, rotate } = getCurrentinitiatorAnimationStyle();
     initiator.style.opacity = opacity;
     initiator.style.transform = `translate(-50%,-50%) scale(${scale}) rotate(${rotate}deg)`;
@@ -284,7 +284,7 @@ const createLasso = (
   };
 
   const initiatorMouseLeaveHandler = () => {
-    hideinitiator();
+    hideInitiator();
   };
 
   const end = ({ merge = false } = {}) => {
@@ -297,7 +297,8 @@ const createLasso = (
 
     clear();
 
-    onEnd(currLassoPos, currLassoPosFlat, { merge });
+    // When `currLassoPos` is empty the user didn't actually lasso
+    if (currLassoPos.length) onEnd(currLassoPos, currLassoPosFlat, { merge });
 
     return currLassoPos;
   };
@@ -355,6 +356,7 @@ const createLasso = (
       extend: extendPublic,
       set,
       showInitiator,
+      hideInitiator,
     });
 
   initiatorParentElement.appendChild(initiator);