Merge pull request #2 from fleming79/async-everywhere

Async everywhere

Author: fleming79

.github/workflows/build.yml

@@ -50,7 +50,7 @@ jobs:
       - name: Install Python
         uses: actions/setup-python@v4
         with:
-          python-version: '3.12'
+          python-version: '3.11'
           architecture: 'x64'
       - uses: actions/download-artifact@v4
         with:

.github/workflows/packaging.yml

@@ -50,12 +50,10 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu, macos, windows]
-        python: ['3.12', '3.13']
+        python: ['3.11', '3.13']
         include:
-          - python: '3.12'
+          - python: '3.11'
             dist: 'ipylab*.tar.gz'
-          - python: '3.13'
-            dist: 'ipylab*.whl'
           - os: windows
             py_cmd: python
             pip_cmd: python -m pip

.pre-commit-config.yaml

@@ -30,15 +30,15 @@ repos:
     hooks:
       - id: check-json5
   - repo: https://github.com/python-jsonschema/check-jsonschema
-    rev: 0.31.3
+    rev: 0.32.1
     hooks:
       - id: check-github-workflows
   - repo: https://github.com/ComPWA/taplo-pre-commit
     rev: v0.9.3
     hooks:
       - id: taplo-format
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.9.10
+    rev: v0.11.4
     hooks:
       - id: ruff
         types_or: [python, jupyter]

.vscode/settings.json

@@ -13,7 +13,6 @@
   "editor.formatOnSave": true,
   "python.terminal.activateEnvInCurrentTerminal": true,
   "python.createEnvironment.trigger": "prompt",
-  "python.analysis.typeCheckingMode": "basic",
   "python.testing.pytestArgs": ["tests"],
   "python.testing.unittestEnabled": false,
   "python.testing.pytestEnabled": true

README.md

@@ -87,9 +87,7 @@ These versions enable:
 - Viewing widgets from kernels inside from other kernels.
 
 ```bash
-# For per-kernel-widget-manager support (Install modified version of ipywidgets, jupyterlab_widgets & widgetsnbextension)
-
-pip install --no-binary --force-reinstall ipylab[per-kernel-widget-manager]
+pip install --no-binary --force-reinstall ipylab
 ```
 
 ## Running the examples locally
@@ -115,13 +113,13 @@ jupyter lab
 
 ```bash
 # create a new conda environment
-mamba create -n ipylab -c conda-forge nodejs python=3.11 -y
+conda create -n ipylab -c conda-forge nodejs python=3.11 -y
 
 # activate the environment
 conda activate ipylab
 
 # install the Python package
-pip install -e .[dev,per-kernel-widget-manager,test] # (with per-kernel-widget-manager)
+pip install -e .[dev,test,examples]
 
 # link the extension files
 jupyter labextension develop . --overwrite
@@ -142,6 +140,10 @@ jlpm lint
 #or
 jlpm lint:check
 
+# Pyright
+
+pip install pyright[nodejs]
+pyright
 ```
 
 ### VS code debugging

examples/code_editor.ipynb

@@ -33,7 +33,7 @@
    "metadata": {},
    "outputs": [],
    "source": [
-    "import asyncio\n",
+    "import anyio\n",
     "\n",
     "import ipylab\n",
     "from ipylab.code_editor import CodeEditorOptions"
@@ -51,12 +51,13 @@
     "    mime_type=\"text/x-python\",\n",
     "    description=\"<b>Code editor</b>\",\n",
     "    tooltip=\"This is a code editor. Code completion is provided for Python\",\n",
-    "    value=\"def test():\\n    ipylab.app.notification.notify('CodeEditor evaluation')\\n\\n# Place the cursor in the CodeEditor and press `Shift Enter`\\ntest()\",\n",
+    "    value=\"def test():\\n    app.notification.notify('CodeEditor evaluation')\\n\\n# Place the cursor in the CodeEditor and press `Shift Enter`\\ntest()\",\n",
     "    layout={\"height\": \"120px\", \"overflow\": \"hidden\"},\n",
     "    description_allow_html=True,\n",
     ")\n",
-    "asyncio.get_event_loop().call_later(0.5, ce.focus)\n",
-    "ce"
+    "display(ce)\n",
+    "await ce.ready()\n",
+    "ce.focus()"
    ]
   },
   {
@@ -123,12 +124,11 @@
     "\n",
     "\n",
     "async def test():\n",
-    "    import asyncio\n",
     "    import random\n",
     "\n",
     "    for _ in range(20):\n",
     "        ce.value = random.choice(values)  # noqa: S311\n",
-    "        await asyncio.sleep(random.randint(10, 300) / 1e3)  # noqa: S311"
+    "        await anyio.sleep(random.randint(10, 300) / 1e3)  # noqa: S311"
    ]
   },
   {
@@ -148,7 +148,7 @@
    "metadata": {},
    "outputs": [],
    "source": [
-    "t = ce.to_task(test())"
+    "await test()"
    ]
   },
   {
@@ -157,16 +157,6 @@
    "id": "11",
    "metadata": {},
    "outputs": [],
-   "source": [
-    "t.cancel()"
-   ]
-  },
-  {
-   "cell_type": "code",
-   "execution_count": null,
-   "id": "12",
-   "metadata": {},
-   "outputs": [],
    "source": [
     "# Place the label above\n",
     "ce.layout.flex_flow = \"column\""
@@ -175,17 +165,17 @@
   {
    "cell_type": "code",
    "execution_count": null,
-   "id": "13",
+   "id": "12",
    "metadata": {},
    "outputs": [],
    "source": [
     "# Add the same editor to the shell.\n",
-    "ipylab.app.shell.add(ce)"
+    "await ce.app.shell.add(ce)"
    ]
   },
   {
    "cell_type": "markdown",
-   "id": "14",
+   "id": "13",
    "metadata": {},
    "source": [
     "### Other mime_types\n",
@@ -196,7 +186,7 @@
   {
    "cell_type": "code",
    "execution_count": null,
-   "id": "15",
+   "id": "14",
    "metadata": {},
    "outputs": [],
    "source": [
@@ -206,7 +196,7 @@
   {
    "cell_type": "code",
    "execution_count": null,
-   "id": "16",
+   "id": "15",
    "metadata": {},
    "outputs": [],
    "source": [
@@ -230,7 +220,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.11.10"
+   "version": "3.12.9"
   }
  },
  "nbformat": 4,