remove fire-and-forget methods | remove _async in methods name

Author: ndonkoHenri

.ci/patch_pubspec_version.py

@@ -1,3 +1,7 @@
+# /// script
+# dependencies = ["pyyaml"]
+# ///
+
 import os
 import pathlib
 import sys
@@ -17,7 +21,7 @@
     "flet",
 ]
 
-with open(pubspec_path, "r") as f:
+with open(pubspec_path) as f:
     data = yaml.safe_load(f)
 
     # patch version

.ci/patch_toml_version.py

@@ -1,3 +1,7 @@
+# /// script
+# dependencies = ["tomlkit"]
+# ///
+
 import os
 import pathlib
 import sys
@@ -14,7 +18,7 @@
 print(f"Patching TOML file {toml_path} to {ver}")
 
 # read
-with open(toml_path, "r") as f:
+with open(toml_path) as f:
     t = tomlkit.parse(f.read())
 
 # patch version

.docstr.yaml

@@ -0,0 +1,7 @@
+paths: src/flet_datatable2
+badge: ./docs/assets/badges/docs-coverage.svg
+skip_file_doc: True
+skip_private: False
+ignore_patterns: # Dict with key/value pairs of file-pattern/node-pattern
+  .*: __post_init__  # Ignore __post_init__ in all files
+fail_under: 50

appveyor.yml

@@ -3,23 +3,20 @@ image: ubuntu
 version: '0.1.{build}'
 
 environment:
+  PYTHON_VERSION: 3.12
   UV_PUBLISH_TOKEN:
     secure: 174ncAbF5IjSIkmioPt62jeSnzmTlRNchUkE4QdjDWH8xK1olYtySXLJpo2q95HcP7lWJky1hv4APESiRRHnBWoY0XRFafzM/mbCDMzG1tZXiXZmpP1qzHAtRP2QSCIg18xh1TMktraUdTi7sbJnjjRhqzgbW1k0kLBxKw79MPFBhYQ/TiGcmaYWZbWVZNY3HCUCb6Dt7bG1OE2Ul9rD1gvs55xwO9Oq9FOVA1VnMYw=
 
-stack:
-- python 3.12
-
 install:
 - source .ci/update_build_version.sh
-- python --version
-- python -m ensurepip --upgrade
-- pip3 install --upgrade tomlkit pyyaml
 - curl -LsSf https://astral.sh/uv/install.sh | sh
-- export PATH=$HOME/.local/bin:$PATH
+- export PATH="$HOME/.local/bin:$PATH"
+- uv python install $PYTHON_VERSION
+- uv python pin $PYTHON_VERSION
 
 build_script:
-- python .ci/patch_toml_version.py pyproject.toml $PYPI_VER
-- python .ci/patch_pubspec_version.py src/flutter/flet_*/pubspec.yaml $PKG_VER
+- uv run .ci/patch_toml_version.py pyproject.toml $PYPI_VER
+- uv run .ci/patch_pubspec_version.py src/flutter/flet_*/pubspec.yaml $PKG_VER
 - (cd src/flutter/* && dart pub get && dart analyze && cd -)
 - uv build
 
@@ -32,4 +29,4 @@ deploy_script:
 artifacts:
 - path: dist/*.whl
 
-test: off
+test: off

examples/datatable2_example/src/example-2.py

@@ -8,17 +8,13 @@ def main(page: ft.Page):
     page.vertical_alignment = ft.MainAxisAlignment.CENTER
     page.horizontal_alignment = ft.CrossAxisAlignment.CENTER
 
-    def select_row(e: ft.ControlEvent):
-        print("on_select_row")
+    def handle_row_selection_change(e: ft.Event[ftd.DataRow2]):
         e.control.selected = not e.control.selected
         e.control.update()
 
     def sort_column(e: ft.DataColumnSortEvent):
         print(f"Sorting column {e.column_index}, ascending={e.ascending}")
 
-    def all_selected(e: ft.ControlEvent):
-        print("All selected")
-
     def get_data_columns():
         data_columns = [
             ftd.DataColumn2(
@@ -72,7 +68,7 @@ def get_data_rows(desserts):
             data_rows.append(
                 ftd.DataRow2(
                     specific_row_height=50,
-                    on_select_change=select_row,
+                    on_select_change=handle_row_selection_change,
                     cells=[
                         ft.DataCell(content=ft.Text(dessert.name)),
                         ft.DataCell(content=ft.Text(dessert.calories)),
@@ -88,7 +84,7 @@ def get_data_rows(desserts):
         return data_rows
 
     page.add(
-        dt := ftd.DataTable2(
+        ftd.DataTable2(
             show_checkbox_column=True,
             expand=True,
             column_spacing=0,
@@ -97,7 +93,7 @@ def get_data_rows(desserts):
             sort_ascending=True,
             bottom_margin=10,
             min_width=600,
-            on_select_all=all_selected,
+            on_select_all=lambda e: print("All selected"),
             columns=get_data_columns(),
             rows=get_data_rows(desserts),
         ),

mkdocs.yml

@@ -110,6 +110,11 @@ plugins:
       alias_type: symlink
   - glightbox
   - section-index
+  - external-images:
+      mappings:
+        - source_dir: examples
+          target_url_path: examples
+          include_exts: [ ".png", ".gif", ".svg" ]
   - mkdocstrings:
       default_handler: python_xref
       handlers:
@@ -135,7 +140,6 @@ plugins:
             preload_modules: [ flet ]
             filters:
               - "!^_"   # Exclude private members starting with only one underscore
-              - "!get_event_field_type"
             extensions:
               - griffe_modernized_annotations
               - griffe_warnings_deprecated
@@ -186,3 +190,4 @@ markdown_extensions:
   - pymdownx.tasklist:
       custom_checkbox: true
   - pymdownx.tilde
+  - pymdownx.blocks.caption

pyproject.toml

@@ -52,13 +52,17 @@ docs = [
     "markdown-exec[ansi] >=1.11.0",
     "pydocstyle >=6.3.0",
     "linkcheckmd >=1.4.0",
+    "mkdocs-external-images",
     { include-group = 'docs-coverage' },
 ]
 all = [
     { include-group = 'dev' },
     { include-group = 'docs' },
 ]
 
+[tool.uv.sources]
+mkdocs-external-images = { git = "https://github.com/flet-dev/mkdocs-external-images", tag = "v0.2.0" }
+
 [build-system]
 requires = ["setuptools"]
 build-backend = "setuptools.build_meta"

src/flet_datatable2/datatable2.py

@@ -20,9 +20,9 @@ class DataTable2(ft.DataTable):
 
     Note:
         `DataTable2` doesn't support
-        [`flet.DataTable.data_row_min_height`][flet.DataTable.data_row_min_height]
-        and [`flet.DataTable.data_row_max_height`][flet.DataTable.data_row_max_height]
-        properties present in the parent [`flet.DataTable`][flet.DataTable].
+        [`DataTable.data_row_min_height`][flet.DataTable.data_row_min_height]
+        and [`DataTable.data_row_max_height`][flet.DataTable.data_row_max_height]
+        properties present in the parent [`DataTable`][flet.DataTable].
         Use [`data_row_height`][(c).] instead.
     """