Skip to content

Commit 20cd201

Browse files
committed
feat(lib): [resolveModule] allow specifier to be URL
Signed-off-by: Lexus Drumgold <unicornware@flexdevelopment.llc>
1 parent b598060 commit 20cd201

3 files changed

Lines changed: 7 additions & 6 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1051,7 +1051,7 @@ Adds support for:
10511051

10521052
#### Parameters
10531053

1054-
- `specifier` (`string`)
1054+
- `specifier` ([`ModuleId`](#moduleid))
10551055
the module specifier to resolve
10561056
- `parent` ([`ModuleId`](#moduleid))
10571057
the url of the parent module

src/lib/__tests__/resolve-module.spec.mts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ describe('unit:lib/resolveModule', () => {
4848
[legacyMain1.name + '/a.js', parent],
4949
[legacyMain2.name, parent],
5050
[moduleSpecifier, import.meta.url],
51-
[nodeUrl.href, import.meta.url],
51+
[nodeUrl, import.meta.url],
5252
[pkg.name + '/package.json', import.meta.url],
5353
[pkgKronk.name, import.meta.url],
5454
[pkgPathe.name + '/dot', import.meta.url],

src/lib/resolve-module.mts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ export default resolveModule
5050
*
5151
* @this {void}
5252
*
53-
* @param {string} specifier
53+
* @param {ModuleId} specifier
5454
* The module specifier to resolve
5555
* @param {ModuleId} parent
5656
* The URL of the parent module
@@ -62,7 +62,7 @@ export default resolveModule
6262
*/
6363
function resolveModule<T extends Awaitable<URL>>(
6464
this: void,
65-
specifier: string,
65+
specifier: ModuleId,
6666
parent: ModuleId,
6767
options?: ResolveModuleOptions | null | undefined
6868
): T
@@ -89,7 +89,7 @@ function resolveModule<T extends Awaitable<URL>>(
8989
*
9090
* @this {void}
9191
*
92-
* @param {string} specifier
92+
* @param {ModuleId} specifier
9393
* The module specifier to resolve
9494
* @param {ModuleId} parent
9595
* The URL of the parent module
@@ -101,10 +101,11 @@ function resolveModule<T extends Awaitable<URL>>(
101101
*/
102102
function resolveModule(
103103
this: void,
104-
specifier: string,
104+
specifier: ModuleId,
105105
parent: ModuleId,
106106
options?: ResolveModuleOptions | null | undefined
107107
): Awaitable<URL> {
108+
specifier = String(specifier)
108109
specifier = resolveAlias(specifier, { ...options, parent }) ?? specifier
109110

110111
/**

0 commit comments

Comments
 (0)