Skip to content

Commit d7c4486

Browse files
fix(FXC-6541): fix failing tests and improve type annotations
- Update translator input data files to use null for default surface output name, matching the new None default - Regenerate service_init ref files from current model defaults - Fix surface_output_class type annotations to use Type[] instead of instance types Made-with: Cursor
1 parent f886c0d commit d7c4486

8 files changed

Lines changed: 944 additions & 941 deletions

File tree

flow360/component/simulation/translator/solver_translator.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -545,7 +545,7 @@ def translate_volume_output(
545545

546546
def translate_imported_surface_output(
547547
output_params: list,
548-
surface_output_class: Union[SurfaceOutput, TimeAverageSurfaceOutput],
548+
surface_output_class: Union[Type[SurfaceOutput], Type[TimeAverageSurfaceOutput]],
549549
coordinate_system_manager=None,
550550
):
551551
"""Translate imported surface output settings."""
@@ -570,7 +570,7 @@ def translate_imported_surface_output(
570570

571571
def _translate_single_surface_output(
572572
output_instance,
573-
surface_output_class: Union[SurfaceOutput, TimeAverageSurfaceOutput],
573+
surface_output_class: Union[Type[SurfaceOutput], Type[TimeAverageSurfaceOutput]],
574574
):
575575
"""Translate a single SurfaceOutput instance to solver config dict."""
576576
is_average = surface_output_class is TimeAverageSurfaceOutput
@@ -603,7 +603,7 @@ def _translate_single_surface_output(
603603

604604
def translate_surface_output(
605605
output_params: list,
606-
surface_output_class: Union[SurfaceOutput, TimeAverageSurfaceOutput],
606+
surface_output_class: Union[Type[SurfaceOutput], Type[TimeAverageSurfaceOutput]],
607607
translated: dict,
608608
):
609609
"""Translate surface output settings.

0 commit comments

Comments
 (0)