Skip to content

updating notebooks#505

Merged
FilipeFcp merged 4 commits into
developfrom
filipe/eapt_192_modesim
May 19, 2026
Merged

updating notebooks#505
FilipeFcp merged 4 commits into
developfrom
filipe/eapt_192_modesim

Conversation

@FilipeFcp

@FilipeFcp FilipeFcp commented May 15, 2026

Copy link
Copy Markdown
Contributor

Updating notebooks for using web.run and ModeSimulation


Note

Low Risk
Changes are limited to example notebooks/documentation code paths and should not affect production libraries, but may break tutorial execution if the new APIs are misused.

Overview
Updates the example notebooks to use the newer web.run workflow and ModeSimulation APIs.

This modernizes the notebook execution patterns to match current client behavior, reducing drift between the notebooks and the recommended simulation setup.

Reviewed by Cursor Bugbot for commit 7658e9a. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor

Spell Check Report

TFLNTidy3d.ipynb:

Cell 38, Line 1: 'voltage-dependent'
  > Next, we run the voltage-dependent mode simulations with `web.run`.

Checked 5 notebook(s). Found spelling errors in 1 file(s).
Generated by GitHub Action run: https://github.com/flexcompute/tidy3d-notebooks/actions/runs/26050074443

@alec-flexcompute alec-flexcompute left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great update as usual @FilipeFcp ! One thing: in RadiativeLossesModeSolver.ipynb cells 9, 11, 13, 19, 21, 24, 27, and 29 maybe use web.run instead of web.Batch for consistency

@jungmin-flex jungmin-flex left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too!

@FilipeFcp

Copy link
Copy Markdown
Contributor Author

Thanks @alec-flexcompute
I updated the notebook, and added another one.

@alec-flexcompute

Copy link
Copy Markdown
Contributor

Looks good, thanks!

@FilipeFcp FilipeFcp merged commit d14f5c2 into develop May 19, 2026
2 checks passed
daquinteroflex pushed a commit that referenced this pull request Jun 1, 2026
updating notebooks to replace Batch and ModeSolver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants