Revert Palik_LowLoss notebook updates#506
Merged
Merged
Conversation
Contributor
|
Spell check passed successfully for 29 notebook(s). |
This reverts commit 5d443d3.
a03728d to
c559975
Compare
momchil-flex
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
5d443d38ea62824ab9b1c19a902881db97d6c379, "Update notebooks to use Palik_LowLoss (Update notebooks to use Palik_LowLoss #499)", for the affected notebooks.custom_dictionary.jsonchanges from the original commit in place.Why
We mirror notebook changes directly to the public notebooks surface. The Palik_LowLoss change has not been included in a public Tidy3D release yet, so publishing these notebooks now can expose unreleased functionality to users.
The Palik_LowLoss notebook update should be re-applied after the next release that includes the corresponding Tidy3D change.
Validation
git show --check --stat --oneline --no-renames HEADcustom_dictionary.jsonis absent from the PR diff.Note
Low Risk
Primarily updates example notebooks to reference
Palik_Losslessmaterials instead ofPalik_LowLoss, with minimal functional impact outside notebook simulation results.Overview
Updates a large set of Jupyter notebooks to stop referencing unreleased
Palik_LowLossmaterial-library entries and instead usePalik_Losslessfor Si and/or SiO2 (including in a fewMultiPhysicsMediumoptical definitions). Also adjusts related explanatory text inChargeSolver.ipynbto reflect the new material name.Reviewed by Cursor Bugbot for commit c559975. Bugbot is set up for automated code reviews on this repo. Configure here.