Skip to content

Revert Palik_LowLoss notebook updates#506

Merged
marcorudolphflex merged 1 commit into
developfrom
codex/revert-palik-lowloss-notebooks
May 19, 2026
Merged

Revert Palik_LowLoss notebook updates#506
marcorudolphflex merged 1 commit into
developfrom
codex/revert-palik-lowloss-notebooks

Conversation

@marcorudolphflex
Copy link
Copy Markdown
Contributor

@marcorudolphflex marcorudolphflex commented May 19, 2026

Summary

  • Reverts 5d443d38ea62824ab9b1c19a902881db97d6c379, "Update notebooks to use Palik_LowLoss (Update notebooks to use Palik_LowLoss #499)", for the affected notebooks.
  • Leaves the custom_dictionary.json changes from the original commit in place.

Why

We mirror notebook changes directly to the public notebooks surface. The Palik_LowLoss change has not been included in a public Tidy3D release yet, so publishing these notebooks now can expose unreleased functionality to users.

The Palik_LowLoss notebook update should be re-applied after the next release that includes the corresponding Tidy3D change.

Validation

  • git show --check --stat --oneline --no-renames HEAD
  • Confirmed custom_dictionary.json is absent from the PR diff.

Note

Low Risk
Primarily updates example notebooks to reference Palik_Lossless materials instead of Palik_LowLoss, with minimal functional impact outside notebook simulation results.

Overview
Updates a large set of Jupyter notebooks to stop referencing unreleased Palik_LowLoss material-library entries and instead use Palik_Lossless for Si and/or SiO2 (including in a few MultiPhysicsMedium optical definitions). Also adjusts related explanatory text in ChargeSolver.ipynb to reflect the new material name.

Reviewed by Cursor Bugbot for commit c559975. Bugbot is set up for automated code reviews on this repo. Configure here.

@marcorudolphflex marcorudolphflex changed the title [codex] Revert Palik_LowLoss notebook updates Revert Palik_LowLoss notebook updates May 19, 2026
@marcorudolphflex marcorudolphflex marked this pull request as ready for review May 19, 2026 13:16
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

Spell check passed successfully for 29 notebook(s).
Generated by GitHub Action run: https://github.com/flexcompute/tidy3d-notebooks/actions/runs/26099865261

@marcorudolphflex marcorudolphflex force-pushed the codex/revert-palik-lowloss-notebooks branch from a03728d to c559975 Compare May 19, 2026 13:19
@marcorudolphflex marcorudolphflex marked this pull request as draft May 19, 2026 13:20
@marcorudolphflex marcorudolphflex marked this pull request as ready for review May 19, 2026 13:25
@marcorudolphflex marcorudolphflex merged commit 18fd47f into develop May 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants