Skip to content

Commit 4a3c50e

Browse files
committed
rebase fixes
1 parent 01964c4 commit 4a3c50e

6 files changed

Lines changed: 8 additions & 18 deletions

File tree

tests/test_components/test_autograd.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1280,7 +1280,7 @@ def test_broadband_adjoint_src_width():
12801280
for f0 in f0_adj_all:
12811281
f = np.array([f0])
12821282

1283-
coords = dict(x=x, y=y, z=z, f=f)
1283+
coords = {"x": x, "y": y, "z": z, "f": f}
12841284

12851285
dataset = td.FieldDataset(Ex=td.ScalarFieldDataArray(np.ones((1, 1, 1, 1)), coords=coords))
12861286

tests/test_components/test_heat.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,9 @@ def make_heat_source():
260260
def make_custom_heat_source():
261261
return HeatSource(
262262
structures=["solid_structure"],
263-
rate=td.SpatialDataArray(np.ones((1, 2, 3)), coords=dict(x=[0], y=[1, 2], z=[3, 4, 5])),
263+
rate=td.SpatialDataArray(
264+
np.ones((1, 2, 3)), coords={"x": [0], "y": [1, 2], "z": [3, 4, 5]}
265+
),
264266
)
265267

266268

tidy3d/components/data/monitor_data.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1908,7 +1908,7 @@ def time_reversed_copy(self) -> FieldData:
19081908
new_data["monitor"] = mnt.updated_copy(store_fields_direction=new_dir)
19091909
return self.copy(update=new_data)
19101910

1911-
def _colocated_propagation_axes_field(self, field_name: Literal[E, H]) -> DataArray:
1911+
def _colocated_propagation_axes_field(self, field_name: Literal["E", "H"]) -> DataArray:
19121912
"""Collect a field DataArray containing all 3 field components and rotate from frame
19131913
with normal axis along z to frame with propagation axis along z.
19141914
"""

tidy3d/components/grid/grid_spec.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2483,14 +2483,8 @@ def _make_grid_and_snapping_lines(
24832483
[None, None],
24842484
[None, None],
24852485
],
2486-
<<<<<<< HEAD
24872486
structure_priority_mode: PriorityMode = "equal",
2488-
) -> Tuple[Grid, List[CoordinateOptional]]:
2489-
||||||| parent of ed17965f (Upgrade all (compatible) generics to built-in types)
2490-
) -> Tuple[Grid, List[CoordinateOptional]]:
2491-
=======
24922487
) -> tuple[Grid, list[CoordinateOptional]]:
2493-
>>>>>>> ed17965f (Upgrade all (compatible) generics to built-in types)
24942488
"""Make the entire simulation grid based on some simulation parameters.
24952489
Also return snappiung point resulted from iterative gap meshing.
24962490

tidy3d/components/scene.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ def medium_map(self) -> dict[StructureMediumType, pd.NonNegativeInt]:
259259
return {medium: index for index, medium in enumerate(self.mediums)}
260260

261261
@cached_property
262-
def sorted_structures(self) -> List[Structure]:
262+
def sorted_structures(self) -> list[Structure]:
263263
"""Returns a list of sorted structures based on their priority.In the sorted list,
264264
latter added structures take higher priority.
265265
@@ -1821,13 +1821,7 @@ def doping_bounds(self):
18211821
acceptors_lims = [1e50, -1e50]
18221822
donors_lims = [1e50, -1e50]
18231823

1824-
<<<<<<< HEAD
18251824
for struct in self.all_structures:
1826-
||||||| parent of 7d108065 (Prefer tuple unpacking over concatenation)
1827-
for struct in [self.background_structure] + list(self.structures):
1828-
=======
1829-
for struct in [self.background_structure, *list(self.structures)]:
1830-
>>>>>>> 7d108065 (Prefer tuple unpacking over concatenation)
18311825
if isinstance(struct.medium.charge, SemiconductorMedium):
18321826
electric_spec = struct.medium.charge
18331827
for doping, limits in zip(

tidy3d/components/tcad/data/sim_data.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,9 +149,9 @@ class HeatChargeSimulationData(AbstractSimulationData):
149149
def plot_field(
150150
self,
151151
monitor_name: str,
152-
field_name: Optional[Literal[temperature, potential]] = None,
152+
field_name: Optional[Literal["temperature", "potential"]] = None,
153153
val: RealFieldVal = "real",
154-
scale: Literal[lin, log] = "lin",
154+
scale: Literal["lin", "log"] = "lin",
155155
structures_alpha: float = 0.2,
156156
robust: bool = True,
157157
vmin: Optional[float] = None,

0 commit comments

Comments
 (0)