fix(tidy3d): FXC-5094-fix-deprecation-warnings-in-tests

Author: marcorudolphflex

tests/config/test_legacy.py

@@ -9,7 +9,11 @@
 
 def test_legacy_logging_level(config_manager):
     cfg = reload_config(profile=config_manager.profile)
-    cfg.logging_level = "DEBUG"
+    with pytest.warns(
+        DeprecationWarning,
+        match=r"config\.logging_level.*deprecated",
+    ):
+        cfg.logging_level = "DEBUG"
     manager = get_manager()
     assert manager.get_section("logging").level == "DEBUG"
 

tests/config/test_legacy_env.py

@@ -1,13 +1,23 @@
 from __future__ import annotations
 
+import importlib
 import os
 import ssl
 import warnings
 
+import pytest
+
 from tidy3d.config import Env, get_manager, reload_config
 from tidy3d.config import config as config_wrapper
 
 
+@pytest.fixture
+def suppress_legacy_env_deprecated_warning(monkeypatch):
+    """Patch Env deprecation helper to a no-op for tests that don't want the warning."""
+    legacy_module = importlib.import_module("tidy3d.config.legacy")
+    monkeypatch.setattr(legacy_module, "_warn_env_deprecated", lambda: None)
+
+
 def test_env_tracks_profile_switch(config_manager):
     """Regression: Env should mirror manager profile switches."""
 
@@ -21,7 +31,11 @@ def test_env_tracks_profile_switch(config_manager):
         reload_config(profile="default")
 
 
-def test_env_pending_overrides_apply_on_activation(mock_config_dir, config_manager):
+def test_env_pending_overrides_apply_on_activation(
+    mock_config_dir,
+    config_manager,
+    suppress_legacy_env_deprecated_warning,
+):
     """Queued overrides should land once the corresponding profile is activated."""
 
     del mock_config_dir
@@ -50,7 +64,12 @@ def test_env_pending_overrides_apply_on_activation(mock_config_dir, config_manag
         reload_config(profile="default")
 
 
-def test_env_vars_follow_profile_switch(mock_config_dir, monkeypatch, config_manager):
+def test_env_vars_follow_profile_switch(
+    mock_config_dir,
+    monkeypatch,
+    config_manager,
+    suppress_legacy_env_deprecated_warning,
+):
     """Environment variables applied via Env should restore previous values on switch."""
 
     del mock_config_dir

tests/test_components/autograd/test_autograd.py

@@ -2157,7 +2157,7 @@ def test_custom_sellmeier(monkeypatch):
     def eps_from(B, C):
         return 1.0 + B * lam2 / (lam2 - C)
 
-    eps_arr = eps_from(B1.values, C1.values) + eps_from(B2.values, C2.values)
+    eps_arr = eps_from(B1.values, C1.values) + eps_from(B2.values, C2.values) + 0j
     dJ = np.conj(ag.holomorphic_grad(lambda e: anp.sum(anp.abs(e)))(eps_arr))
 
     _patch_cmp_custom_to_const(monkeypatch, td.CustomSellmeier, dJ)

tests/test_components/autograd/test_autograd_custom_dispersive_vjps.py

@@ -80,7 +80,9 @@ def test_custom_sellmeier_vjp():
 
     freq = 2.5e14
     lam2 = (C_0 / freq) ** 2
-    eps_arr = 1.0 + B1.values * lam2 / (lam2 - C1.values) + B2.values * lam2 / (lam2 - C2.values)
+    eps_arr = (
+        1.0 + B1.values * lam2 / (lam2 - C1.values) + B2.values * lam2 / (lam2 - C2.values) + 0j
+    )
     dJ = np.conj(ag.holomorphic_grad(_J)(eps_arr))
 
     # Monkeypatch derivative provider
@@ -131,7 +133,7 @@ def test_custom_lorentz_vjp():
         eps_inf.values
         + (de1.values * (f01.values**2)) / den1
         + (de2.values * (f02.values**2)) / den2
-    )
+    ) + 0j
     dJ = np.conj(ag.holomorphic_grad(_J)(eps_arr))
 
     from tidy3d.components import medium as medium_mod
@@ -188,7 +190,7 @@ def test_custom_drude_vjp():
 
     den1 = Drude._den(freq, dl1.values)
     den2 = Drude._den(freq, dl2.values)
-    eps_arr = eps_inf.values - (fp1.values**2) / den1 - (fp2.values**2) / den2
+    eps_arr = eps_inf.values - (fp1.values**2) / den1 - (fp2.values**2) / den2 + 0j
     dJ = np.conj(ag.holomorphic_grad(_J)(eps_arr))
 
     from tidy3d.components import medium as medium_mod
@@ -239,7 +241,7 @@ def test_custom_debye_vjp():
 
     den1 = Debye._den(freq, tau1.values)
     den2 = Debye._den(freq, tau2.values)
-    eps_arr = eps_inf.values + de1.values / den1 + de2.values / den2
+    eps_arr = eps_inf.values + de1.values / den1 + de2.values / den2 + 0j
     dJ = np.conj(ag.holomorphic_grad(_J)(eps_arr))
 
     from tidy3d.components import medium as medium_mod

tests/test_components/autograd/test_autograd_rf_box.py

@@ -11,7 +11,7 @@
 import tidy3d as td
 import tidy3d.web as web
 
-td.config.logging_level = "ERROR"
+td.config.logging.level = "ERROR"
 
 PLOT_FD_ADJ_COMPARISON = False
 NUM_BOXES_PER_FD_TESTS = 1

tests/test_components/autograd/test_autograd_rf_polyslab.py

@@ -11,7 +11,7 @@
 import tidy3d as td
 import tidy3d.web as web
 
-td.config.logging_level = "ERROR"
+td.config.logging.level = "ERROR"
 
 PLOT_FD_ADJ_COMPARISON = False
 NUM_VERTICES_PER_FD_TESTS = 10

tests/test_components/test_heat_charge.py

@@ -2459,7 +2459,7 @@ def test_heat_conduction_simulations():
     # test error if structures aren't conducting
     with pytest.raises(ValidationError):
         struct_error = struct1.updated_copy(
-            medium=struct1.medium.updated_copy(charge=td.ChargeInsulatorMedium)
+            medium=struct1.medium.updated_copy(charge=td.ChargeInsulatorMedium())
         )
         _ = sim.updated_copy(structures=[struct_error])
 

tests/test_components/test_microwave.py

@@ -564,13 +564,15 @@ def test_composite_current_integral_validation():
 
     current_spec = td.AxisAlignedCurrentIntegralSpec(center=(1, 2, 3), size=(0, 1, 1), sign="-")
     voltage_spec = td.AxisAlignedVoltageIntegralSpec(center=(1, 2, 3), size=(0, 0, 1), sign="-")
-    path_spec = td.CompositeCurrentIntegralSpec(path_specs=[current_spec], sum_spec="sum")
-
+    path_spec = td.CompositeCurrentIntegralSpec(path_specs=(current_spec,), sum_spec="sum")
     with pytest.raises(pd.ValidationError):
         path_spec.updated_copy(path_specs=[])
-
-    with pytest.raises(pd.ValidationError):
-        path_spec.updated_copy(path_specs=[voltage_spec])
+    with pytest.warns(
+        UserWarning,
+        match=r"(?s)Pydantic serializer warnings:.*path_specs.*",
+    ):
+        with pytest.raises(pd.ValidationError):
+            path_spec.updated_copy(path_specs=[voltage_spec])
 
 
 def test_composite_current_integral_bounds():

tests/test_components/test_mode_interp.py

@@ -967,11 +967,11 @@ def test_mode_solver_data_stored_freqs(num_freqs, num_points, reduce_data, expec
     )
 
     if rf:
-        mode_spec = td.MicrowaveModeSpec(**mode_spec.dict(exclude={"type"}))
+        mode_spec = td.MicrowaveModeSpec(**mode_spec.model_dump(exclude={"type"}))
         monitor = td.MicrowaveModeSolverMonitor(
-            **monitor.dict(exclude={"type", "mode_spec"}), mode_spec=mode_spec
+            **monitor.model_dump(exclude={"type", "mode_spec"}), mode_spec=mode_spec
         )
-        data = td.ModeSolverData(**data.dict(exclude={"type", "monitor"}), monitor=monitor)
+        data = td.ModeSolverData(**data.model_dump(exclude={"type", "monitor"}), monitor=monitor)
 
     # Check _stored_freqs length
     assert len(data.monitor._stored_freqs) == expected_stored_len, (

tests/test_components/test_scene.py

@@ -146,7 +146,7 @@ def test_get_structure_plot_params():
     pp = SCENE_FULL._get_structure_eps_plot_params(
         medium=SCENE_FULL.medium, freq=1, eps_min=1, eps_max=2
     )
-    expected_color = mpl.cm.get_cmap(STRUCTURE_EPS_CMAP)(0.0)
+    expected_color = plt.get_cmap(STRUCTURE_EPS_CMAP)(0.0)
     assert np.allclose(pp.facecolor, expected_color)
     pp = SCENE_FULL._get_structure_eps_plot_params(medium=td.PEC, freq=1, eps_min=1, eps_max=2)
     assert pp.facecolor == "gold"
@@ -165,7 +165,7 @@ def test_structure_eps_color_mapping():
         norm=norm,
         reverse=False,
     )
-    expected_min = mpl.cm.get_cmap(STRUCTURE_EPS_CMAP)(norm(1.0))
+    expected_min = plt.get_cmap(STRUCTURE_EPS_CMAP)(norm(1.0))
     assert np.allclose(pp_min.facecolor, expected_min)
 
     pp_max = SCENE_FULL._get_structure_eps_plot_params(
@@ -176,7 +176,7 @@ def test_structure_eps_color_mapping():
         norm=norm,
         reverse=False,
     )
-    expected_max = mpl.cm.get_cmap(STRUCTURE_EPS_CMAP)(norm(5.0))
+    expected_max = plt.get_cmap(STRUCTURE_EPS_CMAP)(norm(5.0))
     assert np.allclose(pp_max.facecolor, expected_max)
 
     pp_min_reverse = SCENE_FULL._get_structure_eps_plot_params(
@@ -187,7 +187,7 @@ def test_structure_eps_color_mapping():
         norm=norm,
         reverse=True,
     )
-    expected_min_reverse = mpl.cm.get_cmap(STRUCTURE_EPS_CMAP_R)(norm(1.0))
+    expected_min_reverse = plt.get_cmap(STRUCTURE_EPS_CMAP_R)(norm(1.0))
     assert np.allclose(pp_min_reverse.facecolor, expected_min_reverse)
 
     pp_max_reverse = SCENE_FULL._get_structure_eps_plot_params(
@@ -198,7 +198,7 @@ def test_structure_eps_color_mapping():
         norm=norm,
         reverse=True,
     )
-    expected_max_reverse = mpl.cm.get_cmap(STRUCTURE_EPS_CMAP_R)(norm(5.0))
+    expected_max_reverse = plt.get_cmap(STRUCTURE_EPS_CMAP_R)(norm(5.0))
     assert np.allclose(pp_max_reverse.facecolor, expected_max_reverse)