Skip to content

Fix EME port modes symmetry expansion#2605

Merged
caseyflex merged 1 commit into
developfrom
casey/emesymmetry
Jul 8, 2025
Merged

Fix EME port modes symmetry expansion#2605
caseyflex merged 1 commit into
developfrom
casey/emesymmetry

Conversation

@caseyflex
Copy link
Copy Markdown
Contributor

@caseyflex caseyflex commented Jun 25, 2025

This fixes two related issues:

Copy link
Copy Markdown
Collaborator

@lucas-flexcompute lucas-flexcompute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comment is to maybe define port_modes_raw as an internal property _port_modes_raw if we don't want the user poking there. Unless this is handled similarly for other monitors, then just keep it consistent…

@github-actions
Copy link
Copy Markdown
Contributor

Diff Coverage

Diff: origin/develop...HEAD, staged and unstaged changes

  • tidy3d/components/eme/data/sim_data.py (100%)

Summary

  • Total: 7 lines
  • Missing: 0 lines
  • Coverage: 100%

@caseyflex
Copy link
Copy Markdown
Contributor Author

My only comment is to maybe define port_modes_raw as an internal property _port_modes_raw if we don't want the user poking there. Unless this is handled similarly for other monitors, then just keep it consistent…

Thanks for the comment. In ModeSimulation we also use modes_raw and modes as the symmetry expanded version. I think there is an issue with the way pydantic handles fields starting with an underscore (it doesn't treat them as actual fields).

Comment thread tidy3d/components/eme/data/sim_data.py Outdated
@caseyflex caseyflex force-pushed the casey/emesymmetry branch 2 times, most recently from a9545d4 to 0754a1c Compare June 26, 2025 18:14
@caseyflex caseyflex force-pushed the casey/emesymmetry branch from 0754a1c to 6d72325 Compare July 8, 2025 16:37
@caseyflex caseyflex force-pushed the casey/emesymmetry branch from 6d72325 to 7fc45c2 Compare July 8, 2025 16:38
@caseyflex caseyflex enabled auto-merge (rebase) July 8, 2025 16:38
@caseyflex caseyflex merged commit 6cae72c into develop Jul 8, 2025
23 checks passed
@caseyflex caseyflex deleted the casey/emesymmetry branch July 8, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants