Fix EME port modes symmetry expansion#2605
Merged
Merged
Conversation
beb11df to
2c2309e
Compare
lucas-flexcompute
approved these changes
Jun 25, 2025
Collaborator
lucas-flexcompute
left a comment
There was a problem hiding this comment.
My only comment is to maybe define port_modes_raw as an internal property _port_modes_raw if we don't want the user poking there. Unless this is handled similarly for other monitors, then just keep it consistent…
Contributor
Diff CoverageDiff: origin/develop...HEAD, staged and unstaged changes
Summary
|
Contributor
Author
Thanks for the comment. In |
momchil-flex
approved these changes
Jun 26, 2025
a9545d4 to
0754a1c
Compare
0754a1c to
6d72325
Compare
6d72325 to
7fc45c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two related issues:
EMESimulationData._extract_mode_solver_datadid not retain symmetry information.