Change coordinates when Charge simulations aren't in the xy plane

[marc-flex]

Greptile Summary

Added coordinate transformation functionality to rotate 2D charge simulations from z-plane to y-plane orientation with comprehensive handling of structure components and validation.

• Added _create_charge_copy_xy() method in tidy3d/components/tcad/simulation/heat_charge.py to enable z-plane to y-plane rotation of 2D charge simulations
• Added validation to prevent rotation of 1D charge simulations in _create_charge_copy_xy()
• Implemented coordinate transformations for semiconductor mediums, doping boxes, boundary conditions, and monitors during rotation
• Added comprehensive test case test_charge_copy_xy in tests/test_components/test_heat_charge.py to verify rotation functionality

[greptile-apps]

_{2 files reviewed, 3 comments
Edit PR Review Bot Settings | Greptile}

[greptile-apps]

logic: The assumption that the source should be 'ymin' is not explicitly tested. Add assertion for other source values ('ymax', 'xmin', 'xmax') to ensure complete rotation handling.

[github-actions]

Diff Coverage

Diff: origin/develop...HEAD, staged and unstaged changes

• tidy3d/components/tcad/simulation/heat_charge.py (92.9%): Missing lines 1796,1801,1804,1857,1865

Summary

• Total: 70 lines
• Missing: 5 lines
• Coverage: 92%

tidy3d/components/tcad/simulation/heat_charge.py

  1792 
  1793         sim_types = self._get_simulation_types()
  1794 
  1795         if TCADAnalysisTypes.CHARGE not in sim_types:
! 1796             return self
  1797 
  1798         zero_dims = self.zero_dims
  1799 
  1800         if len(zero_dims) > 1:
! 1801             raise SetupError("Charge simulation can only be 2- or 3-D")
  1802 
  1803         if len(zero_dims) == 0 or zero_dims[0] == 2:
! 1804             return self
  1805 
  1806         def _update_center_size(
  1807             zero_dims: list[int], center: list[float], size: list[float]
  1808         ) -> tuple[list[float], list[float]]:

---

  1853                                         center=new_center, size=new_size, source=source
  1854                                     )
  1855                                 )
  1856                             else:
! 1857                                 new_boxes.append(doping_box)
  1858                             sc_medium = sc_medium.updated_copy(**{key: new_boxes})
  1859                 struct_medium[structure] = structure.medium.updated_copy(charge=sc_medium)
  1860 
  1861         # change structures

---

  1861         # change structures
  1862         new_structures = []
  1863         for structure in self.structures:
  1864             if not isinstance(structure.geometry, Box):
! 1865                 raise SetupError(
  1866                     "2D Charge simulations defined in planes other than xy can only use Box geometries, "
  1867                 )
  1868             else:
  1869                 new_center, new_size = _update_center_size(

---

[dbochkov-flexcompute]

it seems like we don't really need to put this in the frontend? Just thinking that if we need to fix anything later, we would need make changes to frontend instead of just backend

[marc-flex]

it seems like we don't really need to put this in the frontend? Just thinking that if we need to fix anything later, we would need make changes to frontend instead of just backend

I think you're right. I'll do all modifications in this PR and then I'll think how to move this to backend

[marc-flex]

Closing this PR since coordinate transformation is dealt with entirely in the back end