Add interval_space to EMEFieldMonitor#2622
Merged
Merged
Conversation
caseyflex
force-pushed
the
casey/emeintervalspace
branch
from
7312128 to
4105278
Compare
tomflexcompute
approved these changes
Jul 3, 2025
Contributor
tomflexcompute
left a comment
tomflexcompute
left a comment
There was a problem hiding this comment.
Great addition! Thanks @caseyflex
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
caseyflex
force-pushed
the
casey/emeintervalspace
branch
from
4105278 to
73f5e07
Compare
caseyflex
force-pushed
the
casey/emeintervalspace
branch
from
73f5e07 to
a04e818
Compare
Contributor
Diff CoverageDiff: origin/develop...HEAD, staged and unstaged changes
Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds downsampling support in EMEFieldMonitor, to allow user to reduce data generation, storage, transfer when possible.
Greptile Summary
Adds downsampling capability to EMEFieldMonitor by modifying interval_space to accept PositiveInt values, enabling reduced data generation and storage requirements.
tidy3d/components/eme/monitor.pyto allow custom interval spacing in EMEFieldMonitor recordings