fix(style): remove global styles that interfere with structure plots (FXC-1802)#2659
Merged
frederikschubertflex merged 3 commits intoJul 16, 2025
Merged
Conversation
Collaborator
yaugenst-flex
left a comment
There was a problem hiding this comment.
Change looks fine but there seems to be a failing test?
momchil-flex
approved these changes
Jul 15, 2025
Contributor
Author
|
Fixed the test! So after the suite has finished this is good to go. |
Contributor
Diff CoverageDiff: origin/develop...HEAD, staged and unstaged changesNo lines with coverage information in this diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts some of the automatic global styles that were added in #2428 due to visualisation issues in structure plots.
Greptile Summary
This PR makes a focused change to the global matplotlib style settings in
tidy3d/style.mplstyleto fix visualization issues with structure plots. The changes remove automatic grid lines and custom edge colors that were causing interference with structure plot rendering, while maintaining the color cycle definition.Specifically, the PR:
axes.grid: Trueandgrid.linestyle: :)axes.edgecolor: "#ECEBEA")This change reverts part of PR #2428 where these global styles were initially added, as they were found to cause unintended effects on structure plot visualizations.
Confidence score: 5/5
tidy3d/style.mplstyle- verify that removing these style settings doesn't negatively impact other visualization use cases.1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile