Skip to content

Commit 606cc15

Browse files
authored
Fix CI errors (#15)
1 parent 992b1a1 commit 606cc15

5 files changed

Lines changed: 19 additions & 22 deletions

File tree

.github/workflows/_validate.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,18 +62,18 @@ jobs:
6262
if: steps.playwright-cache.outputs.cache-hit != 'true'
6363

6464
# While most of the test suite is self-contained, the tests for the demo
65-
# servers require a prod build of @atj/server.
65+
# servers require a prod build of @flexion/forms-server.
6666
- name: Build
6767
run: pnpm build
6868

6969
- name: Make directory for build artifacts
7070
run: mkdir -p output/build-artifacts
7171

7272
- name: Spotlight app performance budget
73-
run: pnpm --filter @atj/spotlight size:ci > output/build-artifacts/spotlight-size-output.txt
73+
run: pnpm --filter @flexion/forms-spotlight size:ci > output/build-artifacts/spotlight-size-output.txt
7474

7575
- name: Design package performance budget
76-
run: pnpm --filter @atj/design size:ci > output/build-artifacts/design-size-output.txt
76+
run: pnpm --filter @flexion/forms-design size:ci > output/build-artifacts/design-size-output.txt
7777

7878
- name: Upload size:ci results
7979
uses: actions/upload-artifact@v4

.github/workflows/claude-code-review.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,14 @@ jobs:
1717
# github.event.pull_request.user.login == 'external-contributor' ||
1818
# github.event.pull_request.user.login == 'new-developer' ||
1919
# github.event.pull_request.author_association == 'FIRST_TIME_CONTRIBUTOR'
20-
20+
2121
runs-on: ubuntu-latest
2222
permissions:
2323
contents: read
2424
pull-requests: read
2525
issues: read
2626
id-token: write
27-
27+
2828
steps:
2929
- name: Checkout repository
3030
uses: actions/checkout@v4
@@ -46,12 +46,11 @@ jobs:
4646
- Performance considerations
4747
- Security concerns
4848
- Test coverage
49-
49+
5050
Use the repository's CLAUDE.md for guidance on style and conventions. Be constructive and helpful in your feedback.
5151
5252
Use `gh pr comment` with your Bash tool to leave your review as a comment on the PR.
53-
53+
5454
# See https://github.com/anthropics/claude-code-action/blob/main/docs/usage.md
5555
# or https://docs.claude.com/en/docs/claude-code/sdk#command-line for available options
5656
claude_args: '--allowed-tools "Bash(gh issue view:*),Bash(gh search:*),Bash(gh issue list:*),Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*),Bash(gh pr list:*)"'
57-

.github/workflows/release.yml

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -29,17 +29,6 @@ jobs:
2929
- name: Install dependencies
3030
run: pnpm install
3131

32-
- name: Cache Playwright binaries
33-
uses: actions/cache@v4
34-
id: playwright-cache
35-
with:
36-
path: ~/.cache/ms-playwright
37-
key: ${{ runner.os }}-playwright-${{ inputs.playwright_version }}
38-
39-
- name: Install Playwright
40-
run: pnpm dlx playwright@${{ inputs.playwright_version }} install --with-deps
41-
if: steps.playwright-cache.outputs.cache-hit != 'true'
42-
4332
- name: Build packages
4433
run: pnpm run build
4534

packages/forms/src/patterns/attachment/config.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,15 @@ export type AttachmentPattern = Pattern<AttachmentConfigSchema>;
99
export const configSchema = z.object({
1010
label: z.string().min(1, message.patterns.attachment.fieldLabelRequired),
1111
required: z.boolean(),
12-
maxAttachments: z.coerce.number().int().gt(0),
13-
maxFileSizeMB: z.coerce.number().int().gt(1).lte(10),
12+
maxAttachments: z.coerce
13+
.number()
14+
.int()
15+
.gt(0, { message: 'Number must be greater than 0' }),
16+
maxFileSizeMB: z.coerce
17+
.number()
18+
.int()
19+
.gt(1)
20+
.lte(10, { message: 'Number must be less than or equal to 10' }),
1421
allowedFileTypes: z.union([
1522
z
1623
.array(

packages/forms/src/patterns/phone-number/phone-number.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,9 @@ export type PhoneNumberPatternOutput = z.infer<
2222
export const createPhoneSchema = (data: PhoneNumberPattern['data']) => {
2323
const phoneSchema = z
2424
.string()
25-
.regex(/^(\d{3}-\d{3}-\d{4}|\d{10})$/, 'Invalid phone number format')
25+
.regex(/^(\d{3}-\d{3}-\d{4}|\d{10})$/, {
26+
message: 'Invalid phone number format',
27+
})
2628
.transform(value => {
2729
const digits = value.replace(/[^\d]/g, '');
2830
return `${digits.slice(0, 3)}-${digits.slice(3, 6)}-${digits.slice(6)}`;

0 commit comments

Comments
 (0)