Fix node.js dependency issue in browser bundle

Author: danielnaab

apps/cli/src/cli-controller/forms.ts

@@ -3,7 +3,8 @@ import { Command } from 'commander';
 
 import { commands } from '@flexion/forms-infra-core';
 import { type Context } from './types.js';
-import { createFormService, createFormsRepository, defaultFormConfig, createTestPdfParser, parsePdf as parsePdfCore } from '@flexion/forms-core';
+import { createFormService, createFormsRepository, defaultFormConfig, parsePdf as parsePdfCore } from '@flexion/forms-core';
+import { createTestPdfParser } from '@flexion/forms-core/documents/pdf/context';
 import { createFilesystemDatabaseContext } from '@flexion/forms-database/context';
 
 export const addFormCommands = (ctx: Context, cli: Command) => {

apps/spotlight/src/context.ts

@@ -2,7 +2,7 @@ import {
   type FormConfig,
   type FormService,
   createFormService,
-  createNoopPdfParser,
+  createSimpleFakeParser,
 } from '@flexion/forms-core';
 import { defaultFormConfig } from '@flexion/forms-core';
 import { BrowserFormRepository } from '@flexion/forms-core/context';
@@ -44,7 +44,7 @@ const createAppFormService = () => {
       repository,
       config: defaultFormConfig,
       isUserLoggedIn: () => true,
-      parser: createNoopPdfParser(),
+      parser: createSimpleFakeParser(),
     });
   } else {
     return createTestBrowserFormService();

packages/forms/package.json

@@ -20,6 +20,11 @@
       "types": "./dist/types/context/index.d.ts",
       "import": "./dist/esm/context.js",
       "require": "./dist/cjs/context.js"
+    },
+    "./documents/pdf/context": {
+      "types": "./dist/types/documents/pdf/context.d.ts",
+      "import": "./dist/esm/documents/pdf/context.js",
+      "require": "./dist/cjs/documents/pdf/context.js"
     }
   },
   "scripts": {

packages/forms/rollup.config.js

@@ -14,6 +14,7 @@ export default {
   input: {
     index: 'src/index.ts',
     context: 'src/context/index.ts',
+    'documents/pdf/context': 'src/documents/pdf/context.ts',
   },
   output: [
     {

packages/forms/src/context/test/index.ts

@@ -1,5 +1,5 @@
 import { BrowserFormRepository } from '../browser/form-repo.js';
-import { createTestPdfParser } from '../../documents/pdf/index.js';
+import { createSimpleFakeParser } from '../../documents/pdf/index.js';
 import { defaultFormConfig } from '../../patterns/index.js';
 import { type FormService, createFormService } from '../../services/index.js';
 
@@ -15,7 +15,7 @@ export const createTestBrowserFormService = (
     repository,
     config: defaultFormConfig,
     isUserLoggedIn: () => true,
-    parser: createTestPdfParser(),
+    parser: createSimpleFakeParser(),
   });
   if (testData) {
     Object.entries(testData).forEach(([id, blueprint]) => {

packages/forms/src/documents/__tests__/doj-pardon-marijuana.test.ts

@@ -91,7 +91,7 @@ describe('DOJ Pardon Attorney Office - Marijuana pardon application form', () =>
         'doj-pardon-marijuana/demo-application_for_certificate_of_pardon_for_simple_marijuana_possession.pdf'
       );
 
-      const { createTestPdfParser } = await import('../pdf/index.js');
+      const { createTestPdfParser } = await import('../pdf/context.js');
       const { defaultFormConfig } = await import('../../patterns/index.js');
       const parser = createTestPdfParser();
       const result = await parsePdf(

packages/forms/src/documents/pdf/index.ts

@@ -1,4 +1,4 @@
-// Primary PDF parsing API
+// Primary PDF parsing API (Node.js only - uses bedrock)
 export { parsePdf } from './parsing-api.js';
 export type { ParsePdf } from './parsing-api.js';
 
@@ -9,21 +9,25 @@ export type { ExtractedForm } from './domain/schema.js';
 export type { PdfParser } from './services/parser-interface.js';
 export type { PdfParsingContext } from './services/context.js';
 
-// Parser implementations
-export { createBedrockParser } from './adapters/bedrock-parser.js';
+// Parser implementations (Node.js only)
+// NOTE: createBedrockParser is not exported here to avoid pulling in Node.js-only
+// AWS SDK code into browser bundles. Import directly from './adapters/bedrock-parser.js' if needed.
+// export { createBedrockParser } from './adapters/bedrock-parser.js';
 export {
   FakePdfParser,
   createSimpleFakeParser,
 } from './adapters/fake-parser.js';
 
-// Parser factory functions
-export {
-  createProductionPdfParser,
-  createTestPdfParser,
-  createNoopPdfParser,
-} from './context.js';
+// Parser factory functions (Node.js only - createProductionPdfParser uses bedrock)
+// NOTE: These are not exported to avoid pulling Node.js-only code into browser bundles.
+// Import directly from './context.js' if needed in Node.js environments.
+// export {
+//   createProductionPdfParser,
+//   createTestPdfParser,
+//   createNoopPdfParser,
+// } from './context.js';
 
-// PDF generation
+// PDF generation (browser-safe)
 export * from './generate.js';
 export { generateDummyPDF } from './generate-dummy.js';
 

packages/forms/src/testing.ts

@@ -3,7 +3,8 @@ import { createInMemoryDatabaseContext } from '@flexion/forms-database/context';
 
 import type { InternalFormServiceContext } from './context';
 import type { PdfParser } from './documents/pdf/services/parser-interface';
-import { createTestPdfParser, parsePdf as parsePdfCore } from './documents/pdf';
+import { parsePdf as parsePdfCore } from './documents/pdf';
+import { createTestPdfParser } from './documents/pdf/context';
 import { defaultFormConfig } from './patterns';
 import { createFormsRepository } from './repository';
 

packages/server/src/config/services.ts

@@ -3,8 +3,8 @@ import {
   createFormService,
   createFormsRepository,
   defaultFormConfig,
-  createProductionPdfParser,
 } from '@flexion/forms-core';
+import { createProductionPdfParser } from '@flexion/forms-core/documents/pdf/context';
 import { type ServerOptions } from './options.js';
 
 export const createServerFormService = (