fix: sanitize aircraft data in HTML output to prevent XSS - #299
Open
zagers wants to merge 1 commit into
Open
Conversation
Add escapeHtml() utility and apply it to getAirframesModeSLink, getFlightAwareModeSLink, and getFlightAwareIdentLink to prevent script injection via crafted ICAO codes or callsigns. Fixes flightaware#295
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an
escapeHtml()utility and applies it to three link-generation functions that previously inserted unsanitized aircraft data into HTML viainnerHTML.Changes
getAirframesModeSLink— ICAO code stripped to hex-only foronclickhandler, display text HTML-escaped. Also upgraded link fromhttp:// tohttps://`.getFlightAwareModeSLink—codeandidentURL-encoded for href,linkTextHTML-escaped.getFlightAwareIdentLink—identURL-encoded for href,linkTextHTML-escaped.Vulnerability
An attacker controlling the ADS-B feed could inject arbitrary JavaScript through crafted ICAO codes or callsigns (e.g.
"><img src=x onerror=alert(1)>). These values were concatenated directly into HTML strings and inserted viainnerHTML.Fixes #295
Fixes #296