fix: use HTTPS for NEXRAD tiles and airframes.org form - #308
Open
zagers wants to merge 1 commit into
Open
Conversation
NEXRAD weather tiles were loaded over HTTP, allowing MITM manipulation of weather data. The airframes.org lookup form also submitted over HTTP, sending the ICAO code in cleartext. Fixes flightaware#303 Fixes flightaware#304
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades two external resource loads from HTTP to HTTPS to prevent man-in-the-middle manipulation.
Changes
layers.js:174: NEXRAD weather tile URL changed fromhttp://mesonet{1-3}.agron.iastate.edu/...tohttps://mesonet.agron.iastate.edu/...index.html:47: airframes.org form action changed fromhttp://www.airframes.org/tohttps://www.airframes.org/Motivation
NEXRAD tiles loaded over HTTP could be manipulated by a MITM attacker to hide or fabricate weather data. The airframes.org form sent the tracked aircraft ICAO code in cleartext. Both servers support HTTPS.
Fixes #303
Fixes #304