fix: defensive hardening across C backend - #311
Open
zagers wants to merge 1 commit into
Open
Conversation
- generateReceiverJson: replace sprintf with safe_snprintf - Beast escape scan: add sanity limit on eom growth - view1090: check strdup return value - demod_2400: replace assert with runtime check for signal power overlap Fixes flightaware#309
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Grouped low-severity defensive fixes across the C backend for security hardening.
Changes
net_io.c:generateReceiverJson— replacesprintfwithsafe_snprintffor bounds checkingnet_io.c: Beast escape scan — add sanity limit oneomgrowth to prevent excessive expansionview1090.c: Checkstrdupreturn value for OOMdemod_2400.c: Replaceassertwith runtime check for signal power buffer overlap (asserts are compiled out with NDEBUG)Deferred
Some issues from the review were deferred as they are design decisions or already safe in practice:
strlenon hex input (caller NUL-terminates)Fixes #309