You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I see now, I can repro it in 41.
The problem stems from dnf list installed working differently.
The script assumes that running dnf list installed $package will return exit code 1 if the package is not installed, but that's not the case anymore.
Now it will instead return 0 even if it's not installed but exists in the repo.
This needs to be reworked some how
We shouldn't base our code on a deprecated program.
It would also make it so we need to know which fedora version the host is running.
Best solution would be to work out a way that works with old and new dnf
I see now, I can repro it in 41. The problem stems from dnf list installed working differently. The script assumes that running dnf list installed $package will return exit code 1 if the package is not installed, but that's not the case anymore. Now it will instead return 0 even if it's not installed but exists in the repo. This needs to be reworked some how
I think because for dnf5 --installed is the correct option so omitting the dashes just lists instead which would be the same for f40 and earlier if you just used dnf list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.