params: detect sensor availability for "full" overlay preset#1837
params: detect sensor availability for "full" overlay preset#1837matte-schwartz wants to merge 2 commits into
Conversation
|
I wonder if we can figure this out programmatically instead. |
|
that does sound smarter, I think all of them except for gpu_voltage report as |
|
Seems safe to assume 0 for voltage also means unavailable |
|
sorry, haven't forgotten this. will work on it this week. |
Replace the hardcoded handheld device-id list in preset 4 with a per-GPU check of which sensors are actually reported, so on handhelds information is only shown when it is actually available on the device. AMD and Intel report availability via hwmon (a missing node hides the field); AMD voltage is special-cased since its node exists but reads 0, so it is probed at init. Also drops the redundant gpu_efficiency=0, already set for all of preset 4.
ram_temp is read from an spd5118 hwmon sensor. With no such sensor, like on handhelds, mem_temp stays 0 and the "full" layout shows a bogus "0 C". Track whether a sensor was found and only draw ram_temp when one is, so a real 0 C reading still shows.
|
reworked this to make it programmatic as suggested, but review would definitely be appreciated here. I've tested this on a few handhelds now (Deck, Go S, Go 2, MSI Claw w/ Lunar Lake) and they seems to work as expected. also found #2070 while working on this, thinking it was my own regression. |
matte-schwartz
changed the title
2 participants
gets rid of the extra unused fields for the Z2E (Strix/890m) similar to the other Z-series chips and Vangogh when using the "full" layout
Before:
After: