cpu: priority matching for cpu temp#1930
Open
fxzzi wants to merge 1 commit intoflightlessmango:masterfrom
Open
cpu: priority matching for cpu temp#1930fxzzi wants to merge 1 commit intoflightlessmango:masterfrom
fxzzi wants to merge 1 commit intoflightlessmango:masterfrom
Conversation
a722b31 to
8c8d65b
Compare
soerengrunewald
approved these changes
Jan 4, 2026
Contributor
soerengrunewald
left a comment
There was a problem hiding this comment.
LGTM, in fact it should work even better than the original solution. Since the current implementation does not always check if find_input is actually successful, while this does. So we can avoid the situation where we think we have found a valid sensor, but actually have not, therefore 👍 from me.
e38ae79 to
f2cf88a
Compare
Author
|
rebased on top of main. Commit d24ddd1 conflicted but I think I got it working again |
soerengrunewald
suggested changes
May 1, 2026
Contributor
soerengrunewald
left a comment
There was a problem hiding this comment.
After actually trying the code, I notice some issues that need to be changed first.
Author
|
thanks again for the review and recommendations. I have now implemented those changes, as well as rebased on the latest master. I kept the empty check since it shouldn't hurt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before, mangohud would loop through hwmon's in order, and use the first one it found that had a valid temperature sensor that we were looking for.
however, in some cases, the hwmon for a worse sensor can be read first, and therefore used, over a more accurate cpu temp sensor. On my system:
the nct temp sensor would be picked first, and this sensor has very bad accuracy to my real temperature, I've seen it showing upwards of 10C lower than the CPU real temperature, better reported by k10temp.
so, implement a priority system when looping through hwmon.