Do not expose GPG exception details in HTTP 500 responses#3
Open
flightlesstux wants to merge 1 commit intomasterfrom
Open
Do not expose GPG exception details in HTTP 500 responses#3flightlesstux wants to merge 1 commit intomasterfrom
flightlesstux wants to merge 1 commit intomasterfrom
Conversation
_initKeyring() appended the raw GPG library exception message
directly to the InternalErrorException message string:
$msg .= $exception->getMessage();
GPG library errors can contain internal file paths, keyring
locations, key IDs, and passphrase hints that should not be
visible in HTTP responses. The exception is re-thrown as a
500, which CakePHP can surface in API error responses.
Log the exception detail at error level via CakePHP's Log
facade so operators retain full observability, and throw the
InternalErrorException with only the static, safe message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GpgAuthenticator::_initKeyring()appends the raw GPG library exception message directly into theInternalErrorExceptionthat propagates as an HTTP 500 response:GPG library error strings routinely contain internal details that should not reach HTTP clients:
Fix
Log the exception detail internally using CakePHP's
Logfacade and throw theInternalErrorExceptionwith only the static, safe message string:Operators retain full observability through the application log. The original exception is still passed as the third argument to
InternalErrorExceptionso it remains available in the exception chain for debugging.Impact
errorlevel