Skip to content

Do not expose GPG exception details in HTTP 500 responses #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flightlesstux wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −3
Open

Do not expose GPG exception details in HTTP 500 responses #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/Authenticator/GpgAuthenticator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
use Cake\Core\Configure;
use Cake\Http\Exception\ForbiddenException;
use Cake\Http\Exception\InternalErrorException;
use Cake\Log\Log;
use Cake\Http\Response;
use Cake\Http\ServerRequest;
use Cake\ORM\TableRegistry;
Expand Down Expand Up @@ -342,9 +343,12 @@ private function _initKeyring(): void
$this->_gpg->importServerKeyInKeyring();
$this->_gpg->setDecryptKeyFromFingerprint($fingerprint, $passphrase);
} catch (Exception $exception) {
$msg = __('The OpenPGP server key defined in the config cannot be used to decrypt.') . ' ';
$msg .= $exception->getMessage();
throw new InternalErrorException($msg, 500, $exception);
Log::error('GpgAuthenticator: ' . $exception->getMessage());
throw new InternalErrorException(
__('The OpenPGP server key defined in the config cannot be used to decrypt.'),
500,
$exception
);
}
}
}
Expand Down