Fix return values for gr_write methods#2652
Merged
Merged
Conversation
fredrik-johansson
force-pushed
the
gr_write
branch
from
1749479 to
3981633
Compare
d-torrance
approved these changes
Apr 29, 2026
Contributor
d-torrance
left a comment
d-torrance
left a comment
There was a problem hiding this comment.
The tests run succesfully on the Debian ppc64el porterbox after checking out this commit!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix return values for
gr_writeandgr_ctx_writemethods.gr_ctx_writeimplementations were incorrectly declaredvoidinstead ofint. This caused tests to fail on some platforms, e.g. gr_nmod_redc fails on ppc64el #2651.gr_writeandgr_ctx_writeimplementations always returnedGR_SUCCESSregardless of the status of the inner writes. This has been fixed, and the helper functionsgr_stream_writeetc. have been markedWARN_UNUSED_RESULT.