Use Newton iteration for fmpq_poly_(sin|cos|sin_cos)_series#2664
Open
fredrik-johansson wants to merge 1 commit intoflintlib:mainfrom
Open
Use Newton iteration for fmpq_poly_(sin|cos|sin_cos)_series#2664fredrik-johansson wants to merge 1 commit intoflintlib:mainfrom
fredrik-johansson wants to merge 1 commit intoflintlib:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #2663, implement Newton iteration for
fmpq_polysine and cosine and use this instead of the tangent formula. Straightforward translation from thegr_polycode done with the help of Claude. Also slightly improve the basecase code, move out a helper function, and do some light refactoring.Example timings for$f = \log(1+x)$ :
fmpq_poly_sin_series, input seriesSame input for
fmpq_poly_sin_cos_series:This can potentially be optimized a bit more by avoiding some of the intermediate GCDs (in the Karatsuba steps, for example), but that would need closer profiling.