Sage autogen flint 3.5.0#2666
Open
videlec wants to merge 2 commits intoflintlib:mainfrom
Open
Conversation
Collaborator
|
Did you intend to make this PR against the 3.5 branch? |
Contributor
Author
|
Somehow yes, because I wanted the auto-generation in SageMath to work on flint 3.5. Nevertheless, if you intend to not do any update to the 3.5 branch I will be happy to rebase it on 3.6. |
Collaborator
|
I think it would be more convenient if you rebase this against the main branch since the main branch in any case wants fixing too. If we decide to do a 3.5.1 bugfix release, we can cherry-pick it on the 3.5 branch. |
videlec
force-pushed
the
sage-autogen-flint-3.5.0
branch
from
8d2b97d to
5ab35c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make some tiny cleaning in order for sage auto-generation of header files to work.
See sagemath/sage#42146