FFT context initialization speedup#2690
Merged
Merged
Conversation
d2b60ac to
8d040f4
Compare
Collaborator
|
Did you profile this? How big is the speedup? |
Contributor
Author
|
Most significant case: About 20% for small n (n = 1500) and large p (p ~ 50 bits) with the benchmark added in #2681. before: after: Mostly the culprit is the factorization of |
Collaborator
|
OK, that looks quite good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #2681 (now merged).
Note that now initialization hard-fail for primes with insufficient 2-valuation instead of just fill the root table with garbage values. This can be reverted.
Also primes with 2-valuation less than 12 is supported.
The change to no longer compute primitive root speed things up but is backwards incompatible in case someone access the
primitive_rootfield.It's not clear if we really want the interface of
n_primitive_root_prime_prefactorandn_quadratic_nonresidueto be that general.