Aaumkar/network subnet v0.1#1079
Conversation
xMasterX
left a comment
There was a problem hiding this comment.
Hi, I was not able to even compile the app without fixing the code 🥲
App works OK after doing fix of this error
error: "CHAR_WIDTH" redefined [-Werror]
lib/gcc/arm-none-eabi/12.3.1/include-fixed/limits.h:130: note: this is the location of the previous definition
130 | # define CHAR_WIDTH __SCHAR_WIDTH__
Here is the fixed version for you, push that into your repo and update commit sha here
network_subnet-main.zip
But one thing I haven't fixed is the icon network_subnet.png file, please fix that yourself, it should be black and white only like #00000 and #FFFFFF colors
No transparency or any other color, 1 bit B&W only
Tag me when its ready to re-review
|
Hey!! I'm sorry I missed this. I tried to ensure it worked. (I have some questions but I'll google them first.) I'll push the changes you made. Thank you for fixing it. I will fix the image as well. I didn't know any 10x10 image editors so I used the one on Flipper itself. I presumed it would work. But I will look into the details. |
You can use https://www.pixilart.com/draw |
|
Hey @xMasterX , I have made the changes you suggested. I understand that CHAR_WIDTH is used by some other code somewhere and that conflicted with my name. I'll remember this from now on. Also changed the image. Hope it works now. Thanks! |
|
Hey again, There was another potential collision with TAG, renamed that too now. |
|
You need to fix app category in .fam file and update commit sha
|
|
This is weird. I had this error locally with It is working with current setting python3 tools/bundle.py --nolint applications/tools/network_subnet/manifest.yml bundle.zip
19:05:19.602 [I] Deploying SDK for f7
19:05:19.602 [I] Fetching version info for UpdateChannel.RELEASE from https://update.flipperzero.one/firmware/directory.json
19:05:20.013 [I] Using version: 1.4.3
19:05:20.013 [I] uFBT SDK dir: /Users/aaumkar/.ufbt/current
19:05:20.013 [I] SDK is up-to-date
19:05:20.091 [I] Working in '/private/var/folders/z0/12k0r8vs26l4szsb9k07zhhh0000gn/T/tmpyer7typ9'
19:05:20.093 [I] Loaded app manifest from applications/tools/network_subnet/manifest.yml
19:05:20.093 [I] Cloning https://github.com/aaumkar/network_subnet.git to /private/var/folders/z0/12k0r8vs26l4szsb9k07zhhh0000gn/T/tmp72ryda32
Cloning into '/private/var/folders/z0/12k0r8vs26l4szsb9k07zhhh0000gn/T/tmp72ryda32'...
remote: Enumerating objects: 142, done.
remote: Counting objects: 100% (142/142), done.
remote: Compressing objects: 100% (77/77), done.
remote: Total 142 (delta 85), reused 114 (delta 57), pack-reused 0 (from 0)
Receiving objects: 100% (142/142), 27.66 KiB | 9.22 MiB/s, done.
Resolving deltas: 100% (85/85), done.
19:05:20.850 [I] Cloned. Checking out commit 502e2af1e561b606232ea2482263ef75c11ea807
HEAD is now at 502e2af Renaming another potential collision
19:05:20.859 [I] Checked out. Updating submodules
19:05:20.916 [I] Moving /private/var/folders/z0/12k0r8vs26l4szsb9k07zhhh0000gn/T/tmp72ryda32 to /private/var/folders/z0/12k0r8vs26l4szsb9k07zhhh0000gn/T/tmpyer7typ9/code
19:05:20.916 [I] Building
19:05:22.896 [I] Value for 'name' is empty in YAML. Using value 'Network Subnet Helper' from FAM.
19:05:22.896 [I] Value for 'id' is empty in YAML. Using value 'network_subnet' from FAM.
19:05:22.896 [I] Value for 'author' is empty in YAML. Using value 'aaumkar' from FAM.
19:05:22.896 [I] Value for 'category' is empty in YAML. Using value 'tools' from FAM.
19:05:22.896 [I] Value for 'icon' is empty in YAML. Using value 'network_subnet.png' from FAM.
19:05:22.896 [W] Value in YAML for 'short_description' is different from value in FAM: 'A tool to view network subnets and other details.' / 'An app to help with IPv4 Subnets'. Using value from YAML.
19:05:22.896 [I] Value for 'targets' is empty in YAML. Using value '['all']' from FAM.
19:05:22.896 [I] Value for 'version' is empty in YAML. Using value '0.1' from FAM.
19:05:22.896 [I] Including changelog from file /private/var/folders/z0/12k0r8vs26l4szsb9k07zhhh0000gn/T/tmpyer7typ9/code/CHANGELOG.md
19:05:22.918 [I] Saving updated manifest with skip_source_code=False
19:05:22.922 [I] Bundle created: bundle.zipIf I do "Tools" in manifest, it fails locally. |
|
Anyway, I can change the category to Tools in the |
python3 tools/bundle.py --nolint applications/tools/network_subnet/manifest.yml bundle.zip
19:15:47.208 [I] Deploying SDK for f7
19:15:47.208 [I] Fetching version info for UpdateChannel.RELEASE from https://update.flipperzero.one/firmware/directory.json
19:15:47.609 [I] Using version: 1.4.3
19:15:47.610 [I] uFBT SDK dir: /Users/aaumkar/.ufbt/current
19:15:47.610 [I] SDK is up-to-date
19:15:47.713 [I] Working in '/private/var/folders/z0/12k0r8vs26l4szsb9k07zhhh0000gn/T/tmpcwqhuzab'
19:15:47.715 [I] Loaded app manifest from applications/tools/network_subnet/manifest.yml
19:15:47.715 [I] Cloning https://github.com/aaumkar/network_subnet.git to /private/var/folders/z0/12k0r8vs26l4szsb9k07zhhh0000gn/T/tmpoyztso8z
Cloning into '/private/var/folders/z0/12k0r8vs26l4szsb9k07zhhh0000gn/T/tmpoyztso8z'...
remote: Enumerating objects: 144, done.
remote: Counting objects: 100% (144/144), done.
remote: Compressing objects: 100% (80/80), done.
remote: Total 144 (delta 86), reused 114 (delta 56), pack-reused 0 (from 0)
Receiving objects: 100% (144/144), 27.83 KiB | 9.28 MiB/s, done.
Resolving deltas: 100% (86/86), done.
19:15:48.360 [I] Cloned. Checking out commit a0babc23c69ae8386948b4cfcd02ccf7838939d2
HEAD is now at a0babc2 Fix category
19:15:48.368 [I] Checked out. Updating submodules
19:15:48.431 [I] Moving /private/var/folders/z0/12k0r8vs26l4szsb9k07zhhh0000gn/T/tmpoyztso8z to /private/var/folders/z0/12k0r8vs26l4szsb9k07zhhh0000gn/T/tmpcwqhuzab/code
19:15:48.431 [I] Building
19:15:48.741 [I] Value for 'name' is empty in YAML. Using value 'Network Subnet Helper' from FAM.
19:15:48.741 [I] Value for 'id' is empty in YAML. Using value 'network_subnet' from FAM.
19:15:48.741 [I] Value for 'author' is empty in YAML. Using value 'aaumkar' from FAM.
19:15:48.741 [I] Value for 'category' is empty in YAML. Using value 'Tools' from FAM.
19:15:48.741 [I] Value for 'icon' is empty in YAML. Using value 'network_subnet.png' from FAM.
19:15:48.741 [W] Value in YAML for 'short_description' is different from value in FAM: 'A tool to view network subnets and other details.' / 'An app to help with IPv4 Subnets'. Using value from YAML.
19:15:48.741 [I] Value for 'targets' is empty in YAML. Using value '['all']' from FAM.
19:15:48.741 [I] Value for 'version' is empty in YAML. Using value '0.1' from FAM.
19:15:48.745 [E] App category 'Tools' in manifest does not match category 'tools' from path 'applications/tools/network_subnet/manifest.yml'Now it throws this above. Would this work when you build perhaps @xMasterX ? |
|
I saw the logs in the job now. I'll push the changed commit SHA. |
Application Submission
A simple application to view details of an IPv4 network subnet. I thought it would be cool to be able to view details whenever I want on my EDC flipper. The user needs to fill in
The app will just calculate the network address, broadcast address number of hosts and subnet mask.
Extra Requirements
No.
Author Checklist (Fill this out)
python3 tools/bundle.py --nolint applications/CATEGORY/APPID/manifest.yml bundle.zipAI usage disclosure (Fill this out):
I have used Claude code to understand flipper library, code structure (SceneManager, ViewDispatcher, ADD_SCENE macros, event handlers etc.). Although I have learnt C programming in school I needed some refresher of functional language and assistance with the understanding. Claude has also reviewed the code.
Reviewer Checklist (Don't fill this out!)