Skip to content

Add Survival Manual app#1088

Open
Radiomanrf wants to merge 1 commit into
flipperdevices:mainfrom
Radiomanrf:Radiomanrf/survival_manual_1.0
Open

Add Survival Manual app#1088
Radiomanrf wants to merge 1 commit into
flipperdevices:mainfrom
Radiomanrf:Radiomanrf/survival_manual_1.0

Conversation

@Radiomanrf

Copy link
Copy Markdown

Application Submission

Survival Manual — an offline survival reference reader. It contains 37 chapters
(421 sections) from the libre Survival Manual, which is derived from the public-domain
US Army field manual FM 21-76. Navigation is Pages → Sections → scrollable text. The
chapter text ships as SD-card assets and each section is loaded on demand by byte
offset, so RAM use stays low regardless of chapter size. This is the initial release (v1.0).

Extra Requirements

None. No additional hardware or software required — the app reads its bundled text
assets from the SD card.

Author Checklist (Fill this out)

  • I've read the contribution guidelines and my PR follows them
  • I own the code I'm submitting or have code owner's permission to submit it
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have validated the manifest file(s) with python3 tools/bundle.py --nolint applications/Tools/survival_manual/manifest.yml bundle.zip

AI usage disclosure (Fill this out):

  • Partially AI assisted (clarify below which code was AI assisted and briefly explain what it does).
  • Fully AI generated

AI was used to convert the upstream Survival Manual wiki text into Flipper-readable
asset files. The manual content is the public-domain US Army FM 21-76, via the GPLv3
ligi/SurvivalManual project.

Reviewer Checklist (Don't fill this out!)

  • Bundle is valid
  • There are no obvious issues with the source code

@xMasterX xMasterX left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, sadly, this app doesn't even compile

/survival_manual.c:27: error: "COUNT_OF" redefined [-Werror]
   27 | #define COUNT_OF(x) (sizeof(x) / sizeof((x)[0]))
      | 
In file included from furi/core/common_defines.h:3,
                 from furi/furi.h:5,
                 from /survival_manual.c:14:
furi/core/core_defines.h:55: note: this is the location of the previous definition
   55 | #define COUNT_OF(x) (sizeof(x) / sizeof(x[0]))
      | 
/survival_manual.c: In function 'open_section':
/survival_manual.c:89:73: error: 'FSOM_OPENING' undeclared (first use in this function)
   89 |     if(storage_file_open(f, furi_string_get_cstr(app->path), FSAM_READ, FSOM_OPENING)) {
      |                                                                         ^~~~~~~~~~~~
/survival_manual.c:89:73: note: each undeclared identifier is reported only once for each function it appears in
/survival_manual.c: In function 'open_page':
/survival_manual.c:121:73: error: 'FSOM_OPENING' undeclared (first use in this function)
  121 |     if(storage_file_open(f, furi_string_get_cstr(app->path), FSAM_READ, FSOM_OPENING)) {
      |                                                                         ^~~~~~~~~~~~
cc1: all warnings being treated as errors

For example FSOM_OPENING is some nonsense

Image

There are 3 possible types of FILE OPEN command and this one is none of them
define COUNT_OF is present within the firmware, and should not be used, you need to use different define name for your specific defines

@xMasterX xMasterX added the fixes needed Unresolved issues with the app requiring maintainer's attention label Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app (new) fixes needed Unresolved issues with the app requiring maintainer's attention

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants