Skip to content

Add FReD FM (fred_fm) v0.11 catalog manifest.#1104

Open
pchmielewski1 wants to merge 4 commits into
flipperdevices:mainfrom
pchmielewski1:pchmielewski1/fred_fm_0.11
Open

Add FReD FM (fred_fm) v0.11 catalog manifest.#1104
pchmielewski1 wants to merge 4 commits into
flipperdevices:mainfrom
pchmielewski1:pchmielewski1/fred_fm_0.11

Conversation

@pchmielewski1

@pchmielewski1 pchmielewski1 commented Jun 23, 2026

Copy link
Copy Markdown

Application Submission

FReD FM (fred_fm) — GPIO app for the FReD FM radio board: TEA5767 FM tuner, PT2257/PT2259-S digital volume, RDS decode, station presets, and RDS debug capture to SD.

Initial catalog submission v0.11. Source repo: https://github.com/pchmielewski1/tea5767-pt22xx-fm-radio-with-volume-control (commit 7b8b8267b05e9f890f935b8f51e93d4864dd6737).

Extra Requirements

Requires FReD FM hardware (TEA5767 module + PT2257 or PT2259-S volume IC on GPIO/I2C). Wiring and board details are in the source repository README.

Author Checklist (Fill this out)

  • I've read the contribution guidelines and my PR follows them
  • I own the code I'm submitting or have code owner's permission to submit it
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have validated the manifest file(s) with python3 tools/bundle.py --nolint applications/GPIO/fred_fm/manifest.yml bundle.zip

AI usage disclosure (Fill this out):

  • Partially AI assisted (clarify below which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

AI was used during app development and for preparing this catalog manifest. Hardware design, assembly, and on-device testing were done by the author.

Reviewer Checklist (Don't fill this out!)

  • Bundle is valid
  • There are no obvious issues with the source code
  • I've ran this application and verified its functionality

pchmielewski1 and others added 2 commits June 23, 2026 18:19
Co-authored-by: Cursor <cursoragent@cursor.com>
Use 162131 as main preview and 131734 as second screenshot.

Co-authored-by: Cursor <cursoragent@cursor.com>
@xMasterX

Copy link
Copy Markdown
Collaborator

Hi, why there is fred_fm_icons.h file with only#pragma once in it?
If you have conflicts with icon names you should not include <assets_icons.h> in your code, which I don't see also, so what purpose this file serves?

Also making this whole app in one .c file with 3500+ lines in it is not the best idea, this is very hard to read

Will do final review after I receive answer from you to first part about that file

@xMasterX xMasterX added the on hold For PRs that cannot be merged right now as is label Jun 30, 2026
Clarify that the app requires the FReD FM expansion board (PCB v1.1).

Co-authored-by: Cursor <cursoragent@cursor.com>
@pchmielewski1

Copy link
Copy Markdown
Author

Hi @xMasterX, thanks for the review.

fred_fm_icons.h: Confirmed — leftover from the rebrand (fmradio_controller_pt2257_icons.h). It contained only #pragma once, was not included anywhere, and the app icon comes from radio.png in application.fam. Removed.

Monolithic radio.c: Agreed. I split the app into focused modules (fred_fm_core.c, fred_fm_audio.c, fred_fm_rds.c, fred_fm_rds_capture.c, fred_fm_ui.c, fred_fm_ui_config.c, fred_fm_ui_buttons.c, fred_fm_app.c) and removed dead code (RDS_RUNTIME_META_* path was permanently disabled). ufbt fap_fred_fm builds cleanly.

Updated source is on main - I will update the commit_sha in this catalog PR once pushed. Thanks!

Includes refactor commit plus set_version.py update for src/ layout.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app (new) on hold For PRs that cannot be merged right now as is

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants