Add NFC QR Presenter#1107
Open
RogerF5-Security wants to merge 3 commits into
Open
Conversation
Collaborator
|
Hello, why did you remove the AI usage disclosure & Reviewer Checklist from the PR description template? |
5ec4afd to
e195065
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Application Submission
Extra Requirements
/ext/apps_data/nfc_presenter/.Author Checklist (Fill this out)
python3 tools/bundle.py --nolint applications/CATEGORY/APPID/manifest.yml bundle.zipValidation performed:
ufbt formatufbt lintufbt build / APPCHK Target 7, API 87.1python tools/bundle.py --nolint applications/Tools/nfc_qr_presenter/manifest.yml bundle_nfc_qr_presenter.zipAI usage disclosure (Fill this out):
AI assistance was used during implementation and release cleanup. The assisted areas include:
src/nfc_qr_presenter.c: menu flow, payload selection, QR share view, input handling, empty-state handling, and lifecycle fixes to avoid crashes when opening or leaving the share view.src/nfc_qr_storage.c: SD-card payload scanning, text/.ndeffile read/write helpers, slug generation, vCard newline handling, and NDEF message generation for URL, vCard, and text payloads.src/nfc_qr_nfc.c: NFC worker structure for exposing the selected NDEF payload as an NTAG-style tag through the Flipper NFC stack.The author provided the requirements, hardware testing feedback, final behavioral decisions, source review, and owns the final submission.
Reviewer Checklist (Don't fill this out!)