Skip to content

Commit cac60fa

Browse files
hz2jdevers
authored andcommitted
dt-bindings: media: rockchip,rk3588-vicap: add rk3576 support
The RK3576 VICAP uses the same register layout and clock setup as the RK3588 one, with two differences: it has five MIPI CSI-2 input ports instead of six and no DVP parallel port. Extend the existing RK3588 binding rather than adding a separate file: add the rockchip,rk3576-vicap compatible and an allOf/if-then block that drops the DVP port@0 and the sixth MIPI port@6, and caps resets at eight, when that compatible is used. Signed-off-by: Jason Devers <dev.json2@gmail.com>
1 parent 47691ff commit cac60fa

1 file changed

Lines changed: 32 additions & 8 deletions

File tree

Documentation/devicetree/bindings/media/rockchip,rk3588-vicap.yaml

Lines changed: 32 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,21 +4,23 @@
44
$id: http://devicetree.org/schemas/media/rockchip,rk3588-vicap.yaml#
55
$schema: http://devicetree.org/meta-schemas/core.yaml#
66

7-
title: Rockchip RK3588 Video Capture (VICAP)
7+
title: Rockchip RK3576 and RK3588 Video Capture (VICAP)
88

99
maintainers:
1010
- Michael Riesch <michael.riesch@collabora.com>
1111

1212
description:
13-
The Rockchip RK3588 Video Capture (VICAP) block features a digital video
14-
port (DVP, a parallel video interface) and six MIPI CSI-2 ports. It receives
15-
the data from camera sensors, video decoders, or other companion ICs and
16-
transfers it into system main memory by AXI bus and/or passes it the image
17-
signal processing (ISP) blocks.
13+
The Rockchip Video Capture (VICAP) block receives data from camera sensors,
14+
video decoders, or other companion ICs and transfers it into system main
15+
memory by AXI bus and/or passes it to the image signal processing (ISP)
16+
blocks. On RK3588 it features a digital video port (DVP, a parallel video
17+
interface) and six MIPI CSI-2 ports. RK3576 has no DVP and five MIPI CSI-2
18+
ports.
1819

1920
properties:
2021
compatible:
2122
enum:
23+
- rockchip,rk3576-vicap
2224
- rockchip,rk3588-vicap
2325

2426
reg:
@@ -47,6 +49,7 @@ properties:
4749
maxItems: 1
4850

4951
resets:
52+
minItems: 8
5053
maxItems: 9
5154

5255
rockchip,grf:
@@ -63,7 +66,8 @@ properties:
6366
port@0:
6467
$ref: /schemas/graph.yaml#/$defs/port-base
6568
unevaluatedProperties: false
66-
description: The digital video port (DVP, a parallel video interface).
69+
description:
70+
The digital video port (DVP, a parallel video interface). RK3588 only.
6771

6872
properties:
6973
endpoint:
@@ -124,7 +128,8 @@ properties:
124128

125129
port@6:
126130
$ref: /schemas/graph.yaml#/properties/port
127-
description: Port connected to the MIPI CSI-2 receiver 5 output.
131+
description:
132+
Port connected to the MIPI CSI-2 receiver 5 output. RK3588 only.
128133

129134
properties:
130135
endpoint:
@@ -138,6 +143,25 @@ required:
138143
- clocks
139144
- ports
140145

146+
allOf:
147+
- if:
148+
properties:
149+
compatible:
150+
contains:
151+
const: rockchip,rk3576-vicap
152+
then:
153+
properties:
154+
resets:
155+
maxItems: 8
156+
ports:
157+
properties:
158+
port@0: false
159+
port@6: false
160+
else:
161+
properties:
162+
resets:
163+
minItems: 9
164+
141165
additionalProperties: false
142166

143167
examples:

0 commit comments

Comments
 (0)