Fix LINUX_OUT defaults to prevent parallel kernel cross-contamination (#79)#109
Closed
stuartmhannon wants to merge 1 commit into
Closed
Conversation
Both build-kernel-mainline.sh and build-kernel-bsp.sh defaulted to LINUX_OUT=prebuilt/linux. Running them in parallel (even with --no-kernel on one) corrupted each other's output since both wrote to the same directory. Change the defaults to distinct paths: build-kernel-mainline.sh → prebuilt/linux-mainline build-kernel-bsp.sh → prebuilt/linux-bsp Update README to reflect that parallel runs are now safe. Closes flipperdevices#79.
Collaborator
|
Duplicate of #110 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both
build-kernel-mainline.shandbuild-kernel-bsp.shdefaulted toLINUX_OUT=prebuilt/linux. Running them in parallel (even with--no-kernelon one) corrupted each other's output since both wrote to the same directory. This is the audit remediation from ponytail audit item in task 158.Changes
LINUX_OUTfromprebuilt/linuxtoprebuilt/linux-mainlineLINUX_OUTfromprebuilt/linuxtoprebuilt/linux-bspTesting
The scripts continue to use the same
LINUX_OUTenv var override mechanism, so existing CI and manual builds that setLINUX_OUTexplicitly are unaffected. Only the fallback default changes.Closes #79