fix: isolate parallel kernel build output directories#110
Open
stuartmhannon wants to merge 1 commit into
Open
Conversation
Changes LINUX_OUT defaults so build-kernel-mainline.sh writes to prebuilt/linux-mainline and build-kernel-bsp.sh writes to prebuilt/linux-bsp, preventing cross-contamination during parallel builds. Closes flipperdevices#79
Collaborator
|
Hmm, did you test it? I believe it will now fail at the build-rootfs stage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
LINUX_OUTdefaults sobuild-kernel-mainline.shwrites toprebuilt/linux-mainlineandbuild-kernel-bsp.shwrites toprebuilt/linux-bsp, preventing cross-contamination during parallel builds.LINUX_OUT=prebuilt/linux→LINUX_OUT=prebuilt/linux-mainlineLINUX_OUT=prebuilt/linux→LINUX_OUT=prebuilt/linux-bspprebuilt/linux/→prebuilt/linux-mainline/andprebuilt/linux-bsp/) and the "parallel build warning" paragraph (now states it is safe to run in parallel).Closes #79