fix(storage): add PinnableSnapshot interface for atomic evaluation#5771
Open
erka wants to merge 3 commits into
Open
fix(storage): add PinnableSnapshot interface for atomic evaluation#5771erka wants to merge 3 commits into
erka wants to merge 3 commits into
Conversation
dosubot
Bot
added
the
size:L
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5771 +/- ##
==========================================
+ Coverage 58.09% 65.18% +7.08%
==========================================
Files 177 169 -8
Lines 16773 14177 -2596
==========================================
- Hits 9745 9241 -504
+ Misses 6022 4257 -1765
+ Partials 1006 679 -327
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dosubot
Bot
added
size:M
erka
changed the title
Introduces a PinnableSnapshot interface that captures a snapshot at the start of a gRPC request and pins it in the context. Subsequent storage reads during the same evaluation request reuse the pinned snapshot, ensuring consistent atomic evaluation without acquiring locks on every read. Also, ignore mocks in codecov Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a PinnableSnapshot interface that captures a snapshot at the start
of a gRPC request and pins it in the context. Subsequent storage reads
during the same evaluation request reuse the pinned snapshot, ensuring
consistent atomic evaluation without acquiring locks on every read.
Also, ignore mocks in codecov