Update Effect name in tests to be 'costs' instead of 'Costs' Everywhere

Author: FBumann

tests/test_effect.py

@@ -204,7 +204,7 @@ def test_shares(self, basic_flow_system_linopy):
 class TestEffectResults:
     def test_shares(self, basic_flow_system_linopy):
         flow_system = basic_flow_system_linopy
-        flow_system.effects['Costs'].specific_share_to_other_effects_operation['Effect1'] = 0.5
+        flow_system.effects['costs'].specific_share_to_other_effects_operation['Effect1'] = 0.5
         flow_system.add_elements(
             fx.Effect(
                 'Effect1',
@@ -230,9 +230,9 @@ def test_shares(self, basic_flow_system_linopy):
 
         effect_share_factors = {
             'operation': {
-                ('Costs', 'Effect1'): 0.5,
-                ('Costs', 'Effect2'): 0.5 * 1.1,
-                ('Costs', 'Effect3'): 0.5 * 1.1 * 5 + 0.5 * 1.2,  # This is where the issue lies
+                ('costs', 'Effect1'): 0.5,
+                ('costs', 'Effect2'): 0.5 * 1.1,
+                ('costs', 'Effect3'): 0.5 * 1.1 * 5 + 0.5 * 1.2,  # This is where the issue lies
                 ('Effect1', 'Effect2'): 1.1,
                 ('Effect1', 'Effect3'): 1.2 + 1.1 * 5,
                 ('Effect2', 'Effect3'): 5,
@@ -249,8 +249,8 @@ def test_shares(self, basic_flow_system_linopy):
             np.testing.assert_allclose(results.effect_share_factors['invest'][key].values, value)
 
         xr.testing.assert_allclose(
-            results.effects_per_component('operation').sum('component')['Costs'],
-            results.solution['Costs(operation)|total_per_timestep'].fillna(0),
+            results.effects_per_component('operation').sum('component')['costs'],
+            results.solution['costs(operation)|total_per_timestep'].fillna(0),
         )
 
         xr.testing.assert_allclose(
@@ -270,7 +270,7 @@ def test_shares(self, basic_flow_system_linopy):
 
         # Invest mode checks
         xr.testing.assert_allclose(
-            results.effects_per_component('invest').sum('component')['Costs'], results.solution['Costs(invest)|total']
+            results.effects_per_component('invest').sum('component')['costs'], results.solution['costs(invest)|total']
         )
 
         xr.testing.assert_allclose(
@@ -290,7 +290,7 @@ def test_shares(self, basic_flow_system_linopy):
 
         # Total mode checks
         xr.testing.assert_allclose(
-            results.effects_per_component('total').sum('component')['Costs'], results.solution['Costs|total']
+            results.effects_per_component('total').sum('component')['costs'], results.solution['costs|total']
         )
 
         xr.testing.assert_allclose(

tests/test_effects_shares_summation.py

@@ -99,27 +99,27 @@ def test_effect_shares_example():
     """Test the specific example from the effects share factors test."""
     # Create the conversion dictionary based on test example
     conversion_dict = {
-        'Costs': {'Effect1': xr.DataArray(0.5)},
+        'costs': {'Effect1': xr.DataArray(0.5)},
         'Effect1': {'Effect2': xr.DataArray(1.1), 'Effect3': xr.DataArray(1.2)},
         'Effect2': {'Effect3': xr.DataArray(5.0)},
     }
 
     result = calculate_all_conversion_paths(conversion_dict)
 
     # Test direct paths
-    assert result[('Costs', 'Effect1')].item() == 0.5
+    assert result[('costs', 'Effect1')].item() == 0.5
     assert result[('Effect1', 'Effect2')].item() == 1.1
     assert result[('Effect2', 'Effect3')].item() == 5.0
 
     # Test indirect paths
-    # Costs -> Effect2 = Costs -> Effect1 -> Effect2 = 0.5 * 1.1
-    assert result[('Costs', 'Effect2')].item() == 0.5 * 1.1
+    # costs -> Effect2 = costs -> Effect1 -> Effect2 = 0.5 * 1.1
+    assert result[('costs', 'Effect2')].item() == 0.5 * 1.1
 
-    # Costs -> Effect3 has two paths:
-    # 1. Costs -> Effect1 -> Effect3 = 0.5 * 1.2 = 0.6
-    # 2. Costs -> Effect1 -> Effect2 -> Effect3 = 0.5 * 1.1 * 5 = 2.75
+    # costs -> Effect3 has two paths:
+    # 1. costs -> Effect1 -> Effect3 = 0.5 * 1.2 = 0.6
+    # 2. costs -> Effect1 -> Effect2 -> Effect3 = 0.5 * 1.1 * 5 = 2.75
     # Total = 0.6 + 2.75 = 3.35
-    assert result[('Costs', 'Effect3')].item() == 0.5 * 1.2 + 0.5 * 1.1 * 5
+    assert result[('costs', 'Effect3')].item() == 0.5 * 1.2 + 0.5 * 1.1 * 5
 
     # Effect1 -> Effect3 has two paths:
     # 1. Effect1 -> Effect2 -> Effect3 = 1.1 * 5.0 = 5.5

tests/test_flow.py

@@ -101,11 +101,11 @@ def test_effects_per_flow_hour(self, basic_flow_system_linopy):
         co2_per_flow_hour = xr.DataArray(np.linspace(4, 5, timesteps.size), coords=(timesteps,))
 
         flow = fx.Flow(
-            'Wärme', bus='Fernwärme', effects_per_flow_hour={'Costs': costs_per_flow_hour, 'CO2': co2_per_flow_hour}
+            'Wärme', bus='Fernwärme', effects_per_flow_hour={'costs': costs_per_flow_hour, 'CO2': co2_per_flow_hour}
         )
         flow_system.add_elements(fx.Sink('Sink', sink=flow), fx.Effect('CO2', 't', ''))
         model = create_linopy_model(flow_system)
-        costs, co2 = flow_system.effects['Costs'], flow_system.effects['CO2']
+        costs, co2 = flow_system.effects['costs'], flow_system.effects['CO2']
 
         assert_sets_equal(
             set(flow.submodel.variables),
@@ -114,12 +114,12 @@ def test_effects_per_flow_hour(self, basic_flow_system_linopy):
         )
         assert_sets_equal(set(flow.submodel.constraints), {'Sink(Wärme)|total_flow_hours'}, msg='Incorrect constraints')
 
-        assert 'Sink(Wärme)->Costs(operation)' in set(costs.submodel.constraints)
+        assert 'Sink(Wärme)->costs(operation)' in set(costs.submodel.constraints)
         assert 'Sink(Wärme)->CO2(operation)' in set(co2.submodel.constraints)
 
         assert_conequal(
-            model.constraints['Sink(Wärme)->Costs(operation)'],
-            model.variables['Sink(Wärme)->Costs(operation)']
+            model.constraints['Sink(Wärme)->costs(operation)'],
+            model.variables['Sink(Wärme)->costs(operation)']
             == flow.submodel.variables['Sink(Wärme)|flow_rate'] * model.hours_per_step * costs_per_flow_hour,
         )
 
@@ -426,22 +426,22 @@ def test_flow_invest_with_effects(self, basic_flow_system_linopy):
                 minimum_size=20,
                 maximum_size=100,
                 optional=True,
-                fix_effects={'Costs': 1000, 'CO2': 5},  # Fixed investment effects
-                specific_effects={'Costs': 500, 'CO2': 0.1},  # Specific investment effects
+                fix_effects={'costs': 1000, 'CO2': 5},  # Fixed investment effects
+                specific_effects={'costs': 500, 'CO2': 0.1},  # Specific investment effects
             ),
         )
 
         flow_system.add_elements(fx.Sink('Sink', sink=flow), co2)
         model = create_linopy_model(flow_system)
 
         # Check investment effects
-        assert 'Sink(Wärme)->Costs(invest)' in model.variables
+        assert 'Sink(Wärme)->costs(invest)' in model.variables
         assert 'Sink(Wärme)->CO2(invest)' in model.variables
 
         # Check fix effects (applied only when is_invested=1)
         assert_conequal(
-            model.constraints['Sink(Wärme)->Costs(invest)'],
-            model.variables['Sink(Wärme)->Costs(invest)']
+            model.constraints['Sink(Wärme)->costs(invest)'],
+            model.variables['Sink(Wärme)->costs(invest)']
             == flow.submodel.variables['Sink(Wärme)|is_invested'] * 1000
             + flow.submodel.variables['Sink(Wärme)|size'] * 500,
         )
@@ -464,19 +464,19 @@ def test_flow_invest_divest_effects(self, basic_flow_system_linopy):
                 minimum_size=20,
                 maximum_size=100,
                 optional=True,
-                divest_effects={'Costs': 500},  # Cost incurred when NOT investing
+                divest_effects={'costs': 500},  # Cost incurred when NOT investing
             ),
         )
 
         flow_system.add_elements(fx.Sink('Sink', sink=flow))
         model = create_linopy_model(flow_system)
 
         # Check divestment effects
-        assert 'Sink(Wärme)->Costs(invest)' in model.constraints
+        assert 'Sink(Wärme)->costs(invest)' in model.constraints
 
         assert_conequal(
-            model.constraints['Sink(Wärme)->Costs(invest)'],
-            model.variables['Sink(Wärme)->Costs(invest)'] + (model.variables['Sink(Wärme)|is_invested'] - 1) * 500 == 0,
+            model.constraints['Sink(Wärme)->costs(invest)'],
+            model.variables['Sink(Wärme)->costs(invest)'] + (model.variables['Sink(Wärme)|is_invested'] - 1) * 500 == 0,
         )
 
 
@@ -558,12 +558,12 @@ def test_effects_per_running_hour(self, basic_flow_system_linopy):
             'Wärme',
             bus='Fernwärme',
             on_off_parameters=fx.OnOffParameters(
-                effects_per_running_hour={'Costs': costs_per_running_hour, 'CO2': co2_per_running_hour}
+                effects_per_running_hour={'costs': costs_per_running_hour, 'CO2': co2_per_running_hour}
             ),
         )
         flow_system.add_elements(fx.Sink('Sink', sink=flow), fx.Effect('CO2', 't', ''))
         model = create_linopy_model(flow_system)
-        costs, co2 = flow_system.effects['Costs'], flow_system.effects['CO2']
+        costs, co2 = flow_system.effects['costs'], flow_system.effects['CO2']
 
         assert_sets_equal(
             set(flow.submodel.variables),
@@ -586,12 +586,12 @@ def test_effects_per_running_hour(self, basic_flow_system_linopy):
             msg='Incorrect constraints',
         )
 
-        assert 'Sink(Wärme)->Costs(operation)' in set(costs.submodel.constraints)
+        assert 'Sink(Wärme)->costs(operation)' in set(costs.submodel.constraints)
         assert 'Sink(Wärme)->CO2(operation)' in set(co2.submodel.constraints)
 
         assert_conequal(
-            model.constraints['Sink(Wärme)->Costs(operation)'],
-            model.variables['Sink(Wärme)->Costs(operation)']
+            model.constraints['Sink(Wärme)->costs(operation)'],
+            model.variables['Sink(Wärme)->costs(operation)']
             == flow.submodel.variables['Sink(Wärme)|on'] * model.hours_per_step * costs_per_running_hour,
         )
 
@@ -943,7 +943,7 @@ def test_switch_on_constraints(self, basic_flow_system_linopy):
             size=100,
             on_off_parameters=fx.OnOffParameters(
                 switch_on_total_max=5,  # Maximum 5 startups
-                effects_per_switch_on={'Costs': 100},  # 100 EUR startup cost
+                effects_per_switch_on={'costs': 100},  # 100 EUR startup cost
             ),
         )
 
@@ -984,12 +984,12 @@ def test_switch_on_constraints(self, basic_flow_system_linopy):
         )
 
         # Check that startup cost effect constraint exists
-        assert 'Sink(Wärme)->Costs(operation)' in model.constraints
+        assert 'Sink(Wärme)->costs(operation)' in model.constraints
 
         # Verify the startup cost effect constraint
         assert_conequal(
-            model.constraints['Sink(Wärme)->Costs(operation)'],
-            model.variables['Sink(Wärme)->Costs(operation)'] == flow.submodel.variables['Sink(Wärme)|switch|on'] * 100,
+            model.constraints['Sink(Wärme)->costs(operation)'],
+            model.variables['Sink(Wärme)->costs(operation)'] == flow.submodel.variables['Sink(Wärme)|switch|on'] * 100,
         )
 
     def test_on_hours_limits(self, basic_flow_system_linopy):

tests/test_integration.py

@@ -248,7 +248,7 @@ def test_piecewise_conversion(self, flow_system_piecewise_conversion, highs_solv
         assert_almost_equal_numeric(
             comps['Speicher'].submodel.variables['Speicher|PiecewiseEffects|costs'].solution.values,
             454.74666666666667,
-            'Speicher investCosts_segmented_costs doesnt match expected value',
+            'Speicher investcosts_segmented_costs doesnt match expected value',
         )
 
 
@@ -309,13 +309,13 @@ def test_modeling_types_costs(self, modeling_calculation):
             assert_almost_equal_numeric(
                 calc.results.model['costs|total'].solution.item(),
                 expected_costs[modeling_type],
-                f'Costs do not match for {modeling_type} modeling type',
+                f'costs do not match for {modeling_type} modeling type',
             )
         else:
             assert_almost_equal_numeric(
                 calc.results.solution_without_overlap('costs(operation)|total_per_timestep').sum(),
                 expected_costs[modeling_type],
-                f'Costs do not match for {modeling_type} modeling type',
+                f'costs do not match for {modeling_type} modeling type',
             )
 
     def test_segmented_io(self, modeling_calculation):

tests/test_linear_converter.py

@@ -146,7 +146,7 @@ def test_linear_converter_with_on_off(self, basic_flow_system_linopy):
 
         # Create OnOffParameters
         on_off_params = fx.OnOffParameters(
-            on_hours_total_min=10, on_hours_total_max=40, effects_per_running_hour={'Costs': 5}
+            on_hours_total_min=10, on_hours_total_max=40, effects_per_running_hour={'costs': 5}
         )
 
         # Create a linear converter with OnOffParameters
@@ -186,10 +186,10 @@ def test_linear_converter_with_on_off(self, basic_flow_system_linopy):
         )
 
         # Check on_off effects
-        assert 'Converter->Costs(operation)' in model.constraints
+        assert 'Converter->costs(operation)' in model.constraints
         assert_conequal(
-            model.constraints['Converter->Costs(operation)'],
-            model.variables['Converter->Costs(operation)']
+            model.constraints['Converter->costs(operation)'],
+            model.variables['Converter->costs(operation)']
             == model.variables['Converter|on'] * model.hours_per_step * 5,
         )
 
@@ -398,7 +398,7 @@ def test_piecewise_conversion_with_onoff(self, basic_flow_system_linopy):
 
         # Create OnOffParameters
         on_off_params = fx.OnOffParameters(
-            on_hours_total_min=10, on_hours_total_max=40, effects_per_running_hour={'Costs': 5}
+            on_hours_total_min=10, on_hours_total_max=40, effects_per_running_hour={'costs': 5}
         )
 
         # Create a linear converter with piecewise conversion and on/off parameters
@@ -489,10 +489,10 @@ def test_piecewise_conversion_with_onoff(self, basic_flow_system_linopy):
         )
 
         # Verify that the costs effect is applied
-        assert 'Converter->Costs(operation)' in model.constraints
+        assert 'Converter->costs(operation)' in model.constraints
         assert_conequal(
-            model.constraints['Converter->Costs(operation)'],
-            model.variables['Converter->Costs(operation)']
+            model.constraints['Converter->costs(operation)'],
+            model.variables['Converter->costs(operation)']
             == model.variables['Converter|on'] * model.hours_per_step * 5,
         )
 

tests/test_scenarios.py

@@ -67,9 +67,9 @@ def test_system():
         size=InvestParameters(
             minimum_size=0,
             maximum_size=20,
-            specific_effects={'Costs': 100},  # €/kW
+            specific_effects={'costs': 100},  # €/kW
         ),
-        effects_per_flow_hour={'Costs': 20},  # €/MWh
+        effects_per_flow_hour={'costs': 20},  # €/MWh
     )
     generator = Source('Generator', source=power_gen)
 
@@ -83,15 +83,15 @@ def test_system():
         capacity_in_flow_hours=InvestParameters(
             minimum_size=0,
             maximum_size=50,
-            specific_effects={'Costs': 50},  # €/kWh
+            specific_effects={'costs': 50},  # €/kWh
         ),
         eta_charge=0.95,
         eta_discharge=0.95,
         initial_charge_state='lastValueOfSim',
     )
 
     # Create effects and objective
-    cost_effect = Effect(label='Costs', unit='€', description='Total costs', is_standard=True, is_objective=True)
+    cost_effect = Effect(label='costs', unit='€', description='Total costs', is_standard=True, is_objective=True)
 
     # Add all elements to the flow system
     flow_system.add_elements(electricity_bus, generator, demand_sink, storage, cost_effect)