fix: Throw MappingFailureError on failed id mapping

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Author: marcelklehr

src/lib/Diff.ts

@@ -335,6 +335,19 @@ export default class Diff<
             action.payload,
             targetLocation
           )
+          if (action.type !== ActionType.CREATE && typeof action.payload.id !== 'undefined' && typeof newAction.payload.id === 'undefined') {
+            Logger.log(
+              'payload.location = ' +
+              action.payload.location +
+              ' | targetLocation = ' +
+              targetLocation
+            )
+            const diff = new Diff()
+            diff.commit(action)
+            Logger.log('Failed to map id of action ' + diff.inspect())
+            Logger.log(JSON.stringify(mappingsSnapshot, null, '\t'))
+            throw new MappingFailureError(String(action.payload.id))
+          }
         }
 
         if (
@@ -397,6 +410,10 @@ export default class Diff<
           })
         }
 
+        if (action.type !== ActionType.REORDER) {
+          Logger.log('Mapped action', action, newAction)
+        }
+
         newDiff.commit(newAction)
       })
     return newDiff

src/lib/strategies/Merge.ts

@@ -1,4 +1,4 @@
-import { Folder, ItemLocation, ItemType, TItem, TItemLocation, TOppositeLocation } from '../Tree'
+import { Folder, ItemLocation, TItemLocation, TOppositeLocation } from '../Tree'
 import Diff, { CreateAction, MoveAction, PlanStage1 } from '../Diff'
 import Scanner, { ScanResult } from '../Scanner'
 import * as Parallel from 'async-parallel'