Merge pull request #2213 from floccusaddon/perf/improve-build-time

perf(build): Improve build time

Author: marcelklehr

.github/workflows/build.yml

@@ -44,6 +44,14 @@ jobs:
         run: |
           npm ci -f
 
+      - name: Lint code
+        run: |
+          npm run lint
+
+      - name: TypeScript check
+        run: |
+          npm run typecheck
+
       - name: Install dependencies & build
         run: |
           npm run build-release --if-present

gulpfile.js

@@ -104,7 +104,6 @@ const js = async function() {
       resolve()
     })
   )
-  await new Promise(resolve => setTimeout(resolve, 5000))
   statsJson.children.forEach(statsJson => html(statsJson))
   statsJson.children.forEach(statsJson => webpackCheck(statsJson))
 }

package.json

@@ -3,15 +3,16 @@
   "version": "5.8.6",
   "description": "Sync your bookmarks privately across browsers and devices",
   "scripts": {
-    "build": "NODE_OPTIONS=--max-old-space-size=12000 gulp",
-    "build-win": "SET NODE_OPTIONS=--max-old-space-size=12000 & gulp",
-    "build-release": "NODE_OPTIONS=--max-old-space-size=12000 gulp release",
-    "build-release-win": "SET NODE_OPTIONS=--max-old-space-size=12000 & gulp release",
-    "watch": "NODE_OPTIONS=--max-old-space-size=12000 gulp watch",
-    "watch-win": "SET NODE_OPTIONS=--max-old-space-size=12000 & gulp watch",
+    "build": "NODE_OPTIONS=--max-old-space-size=4096 gulp",
+    "build-win": "SET NODE_OPTIONS=--max-old-space-size=4096 & gulp",
+    "build-release": "NODE_OPTIONS=--max-old-space-size=4096 gulp release",
+    "build-release-win": "SET NODE_OPTIONS=--max-old-space-size=4096 & gulp release",
+    "watch": "NODE_OPTIONS=--max-old-space-size=4096 gulp watch",
+    "watch-win": "SET NODE_OPTIONS=--max-old-space-size=4096 & gulp watch",
     "test": "node --unhandled-rejections=strict test/selenium-runner.js",
     "lint": "eslint --ext .js,.vue src",
     "lint:fix": "eslint --ext .js,.vue src --fix",
+    "typecheck": "tsc --noEmit",
     "doiuse": "doiuse dist/js/css/*.css",
     "supportedBrowsers": "echo \"module.exports = $(browserslist-useragent-regexp --allowHigherVersions);\" > supportedBrowsers.js"
   },

tsconfig.json

@@ -9,6 +9,7 @@
     "noImplicitThis": true,
     "esModuleInterop": true,
     "resolveJsonModule": true,
+    "skipLibCheck": true,
     "lib": [
       "DOM",
       "es2019",

webpack.common.js

@@ -12,12 +12,6 @@ const common = {
   },
   module: {
     rules: [
-      {
-        test: /\.(js|vue)$/,
-        use: 'eslint-loader',
-        exclude: /node_modules/,
-        enforce: 'pre',
-      },
       {
         test: /\.css$/,
         use: ['vue-style-loader', 'css-loader'],
@@ -47,7 +41,12 @@ const common = {
       },
       {
         test: /\.tsx?$/,
-        use: 'ts-loader',
+        use: {
+          loader: 'ts-loader',
+          options: {
+            transpileOnly: true,
+          }
+        },
         exclude: /node_modules/,
       },
       {
@@ -56,6 +55,7 @@ const common = {
         use: {
           loader: 'babel-loader',
           options: {
+            cacheDirectory: true,
             presets: [
               [
                 '@babel/preset-env',
@@ -134,7 +134,12 @@ module.exports = [
         },
         {
           test: /\.tsx?$/,
-          use: 'ts-loader',
+          use: {
+            loader: 'ts-loader',
+            options: {
+              transpileOnly: true,
+            }
+          },
           exclude: /node_modules/,
         },
         {
@@ -143,6 +148,7 @@ module.exports = [
           use: {
             loader: 'babel-loader',
             options: {
+              cacheDirectory: true,
               presets: [
                 [
                   '@babel/preset-env',

webpack.prod.js

@@ -16,16 +16,18 @@ module.exports = common.map(common => merge(common, {
     new webpack.DefinePlugin({
       DEBUG: JSON.stringify(false)
     }),
-    sentryWebpackPlugin({
-      authToken: process.env.SENTRY_AUTH_TOKEN,
-      org: "marcel-klehr",
-      project: "floccus",
-      release: {
-        name: packageJSON.version
-      },
-      sourcemaps: {
-        disable: true,
-      }
-    }),
+    ...(process.env.SENTRY_AUTH_TOKEN ? [
+      sentryWebpackPlugin({
+        authToken: process.env.SENTRY_AUTH_TOKEN,
+        org: "marcel-klehr",
+        project: "floccus",
+        release: {
+          name: packageJSON.version
+        },
+        sourcemaps: {
+          disable: true,
+        }
+      })
+    ] : []),
   ]
 }))