Broken URL for OCS capability requests

[ghostshadow]

Which version of floccus are you using?

5.7.0

How many bookmarks do you have, roughly?

300

Are you using other means to sync bookmarks in parallel to floccus?

No

Sync method

Nextcloud Bookmarks

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Firefox 141.0.3 / Linux Desktop

Which version of Nextcloud Bookmarks are you using? (if relevant)

No response

Which version of Nextcloud? (if relevant)

No response

What kind of WebDAV server are you using? (if relevant)

Raw Nextcloud (not Docker) install behind Nginx in a multi service setup (nextcloud not at webserver root but subdirectory).

Describe the Bug

Floccus fails to sync with code 404. The debug log shows, this is happening for the capability request.
The apparent issue is a doubling up of slashes in the URL: https://***/nextcloud//ocs/v2.php/... instead of https://***/nextcloud/ocs/v2.php/....
The offending code is related to the concatenation of the base URL and the OCS relative URL, which inserts an extra slash. (

floccus/src/lib/adapters/NextcloudBookmarks.ts

Line 826 in d496afb

const url = this.normalizeServerURL(this.server.url) + relUrl

in combination with

floccus/src/lib/adapters/NextcloudBookmarks.ts

Line 771 in d496afb

`/ocs/v2.php/cloud/capabilities?format=json`,

)

Expected Behavior

Use correct URL => do not get an error.

To Reproduce

1. Nextcloud not hosted at root of (Nginx) webserver
2. Trigger sync
3. 404 Error

Debug log provided

• I have provided a debug log file

[github-actions]

Hello 👋

Thank you for taking the time to open this issue with floccus. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved. Let me give you a short introduction on what to expect from this issue tracker to avoid misunderstandings.
I'm Marcel. I created floccus a few years ago, and have been maintaining it since. I currently work for Nextcloud
which leaves me with less time for side projects like this one than I used to have.
I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient. It helps when you stick around to answer follow up questions I may have,
as very few bugs can be fixed directly from the first bug report, without any interaction. If information is missing in your bug report
and the issue cannot be solved without it, I will have to close the issue after a while.
Note also that GitHub in general is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
If you cannot lend a helping hand, to continue the development and maintenance of this project in a sustainable way,
I ask that you donate to the project when opening an issue (or at least once your issue is solved), if you're not a donor already.
You can find donation options at https://floccus.org/donate/. Thank you!

One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the Nextcloud forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself.

Thank you for reading through this primer. I look forward to working with you on this issue!
Cheers 💙

[marcelklehr]

Thanks for taking the time to research this and give feedback! I'll publish a fix!