feat(AdditionFailsafe): Extend failsafe mechanism to prevent creation of excessive amounts of bookmarks#1902
Merged
marcelklehr merged 2 commits intodevelopfrom Apr 6, 2025
Merged
Conversation
… of excessive amounts of bookmarks fixes #1900 Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Contributor
There was a problem hiding this comment.
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- _locales/en/messages.json: Language not supported
Comments suppressed due to low confidence (1)
src/test/test.js:2252
- [nitpick] Consider using a more descriptive title for the bookmark in tests instead of the generic 'url' to improve readability.
title: 'url'
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
marcelklehr
force-pushed
the
feat/addition-failsafe
branch
from
0b50418 to
c668101
Compare
Contributor
There was a problem hiding this comment.
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (1)
- _locales/en/messages.json: Language not supported
Comments suppressed due to low confidence (2)
src/test/test.js:2252
- [nitpick] Consider using a more descriptive or unique bookmark title for test-created bookmarks to aid in debugging, as using a generic title like 'url' might make failure tracing less clear.
title: 'url',
src/lib/strategies/Default.ts:370
- [nitpick] Consider refactoring the ratio calculation into a separate variable to improve readability and reduce duplication in logging, ensuring consistency between deletion and addition failsafe checks.
Logger.log('Checking deletion failsafe: ' + countDeleted + '/' + countTotal + '=' + (countDeleted / countTotal))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1900