Remove duplicate MAX_FRAMES_IN_FLIGHT

floppyhammer · floppyhammer · commit 3af56a2c08dc · 2026-07-16T10:47:23.000+08:00
diff --git a/pathfinder/gpu/gl/window_builder.cpp b/pathfinder/gpu/gl/window_builder.cpp
@@ -232,8 +232,6 @@ uint8_t WindowBuilderGl::create_window(const Vec2I &size, const std::string &tit
 #endif
 }
 
-constexpr int MAX_FRAMES_IN_FLIGHT = 2;
-
 std::shared_ptr<Device> WindowBuilderGl::request_device() {
     return std::make_shared<DeviceGl>(MAX_FRAMES_IN_FLIGHT);
 }
diff --git a/pathfinder/gpu/mtl/window_builder.mm b/pathfinder/gpu/mtl/window_builder.mm
@@ -53,8 +53,6 @@
     return sub_windows_.size();
 }
 
-constexpr int MAX_FRAMES_IN_FLIGHT = 2;
-
 std::shared_ptr<Device> WindowBuilderMtl::request_device() {
     id<MTLDevice> device = (__bridge id<MTLDevice>)mtl_device_;
     id<MTLCommandQueue> queue = (__bridge id<MTLCommandQueue>)mtl_cmd_queue_;
diff --git a/pathfinder/gpu/vk/window_builder.cpp b/pathfinder/gpu/vk/window_builder.cpp
@@ -146,8 +146,6 @@ void WindowBuilderVk::initialize_after_surface_creation(VkSurfaceKHR surface) {
     initialized_ = true;
 }
 
-constexpr int MAX_FRAMES_IN_FLIGHT = 2;
-
 std::shared_ptr<Device> WindowBuilderVk::request_device() {
     auto device = std::shared_ptr<DeviceVk>(
         new DeviceVk(device_, physical_device_, graphics_queue_, present_queue_, command_pool_, MAX_FRAMES_IN_FLIGHT));
diff --git a/pathfinder/gpu/window_builder.h b/pathfinder/gpu/window_builder.h
@@ -16,6 +16,8 @@ class Window;
 
 static auto PRIMARY_WINDOW_TITLE = "Primary Window";
 
+constexpr int MAX_FRAMES_IN_FLIGHT = 2;
+
 /// Window management.
 class WindowBuilder {
 public:

Original file line number	Diff line number	Diff line change
`@@ -232,8 +232,6 @@ uint8_t WindowBuilderGl::create_window(const Vec2I &size, const std::string &tit`
`232`	`232`	`#endif`
`233`	`233`	`}`
`234`	`234`
`235`		`-constexpr int MAX_FRAMES_IN_FLIGHT = 2;`
`236`		`-`
`237`	`235`	`std::shared_ptr<Device> WindowBuilderGl::request_device() {`
`238`	`236`	`return std::make_shared<DeviceGl>(MAX_FRAMES_IN_FLIGHT);`
`239`	`237`	`}`
Original file line number	Diff line number	Diff line change
`@@ -53,8 +53,6 @@`
`53`	`53`	`return sub_windows_.size();`
`54`	`54`	`}`
`55`	`55`
`56`		`-constexpr int MAX_FRAMES_IN_FLIGHT = 2;`
`57`		`-`
`58`	`56`	`std::shared_ptr<Device> WindowBuilderMtl::request_device() {`
`59`	`57`	`id<MTLDevice> device = (__bridge id<MTLDevice>)mtl_device_;`
`60`	`58`	`id<MTLCommandQueue> queue = (__bridge id<MTLCommandQueue>)mtl_cmd_queue_;`
Original file line number	Diff line number	Diff line change
`@@ -146,8 +146,6 @@ void WindowBuilderVk::initialize_after_surface_creation(VkSurfaceKHR surface) {`
`146`	`146`	`initialized_ = true;`
`147`	`147`	`}`
`148`	`148`
`149`		`-constexpr int MAX_FRAMES_IN_FLIGHT = 2;`
`150`		`-`
`151`	`149`	`std::shared_ptr<Device> WindowBuilderVk::request_device() {`
`152`	`150`	`auto device = std::shared_ptr<DeviceVk>(`
`153`	`151`	`new DeviceVk(device_, physical_device_, graphics_queue_, present_queue_, command_pool_, MAX_FRAMES_IN_FLIGHT));`