Skip to content

Add new url setting to display the short URL#902

Open
jasondunsmore wants to merge 1 commit into
florianfesti:masterfrom
jasondunsmore:master
Open

Add new url setting to display the short URL#902
jasondunsmore wants to merge 1 commit into
florianfesti:masterfrom
jasondunsmore:master

Conversation

@jasondunsmore
Copy link
Copy Markdown
Contributor

Also, separate url from qr_code, and separate url and qr_code from reference.

Fixes: #901

Also, separate url from qr_code, and separate url and qr_code from reference.

Fixes: florianfesti#901
@florianfesti
Copy link
Copy Markdown
Owner

I am not too keen on adding more Default Settings. What about just using the labels setting for this?

@jasondunsmore
Copy link
Copy Markdown
Contributor Author

I'm not sure what you mean about using the labels setting for this. I meant to close this PR when I closed #901, since the SVG metadata solves my use case. Although it might still be useful to allow qr_code when reference is 0. Let me know if you want a PR with only that change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New "url" setting should be separate from QR code and should not be tied to reference setting

2 participants